Skip to content

[OSDOCS#17008] CQA 2.1 for vSphere IPI installer-provisioned with customizations#115242

Open
maxwelldb wants to merge 1 commit into
openshift:mainfrom
maxwelldb:vsphere-ipi-installer-provisioned-customizations-cqa-osdocs17008
Open

[OSDOCS#17008] CQA 2.1 for vSphere IPI installer-provisioned with customizations#115242
maxwelldb wants to merge 1 commit into
openshift:mainfrom
maxwelldb:vsphere-ipi-installer-provisioned-customizations-cqa-osdocs17008

Conversation

@maxwelldb

@maxwelldb maxwelldb commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Version(s): 4.20+

Issue: OSDOCS-17008

Link to docs preview: 4.20+

QE review:

  • QE has approved this change.

Additional information: CQA pre-migration pass for the installer-provisioned-with-customizations assembly.

…stomizations

Add missing [role="_abstract"] short descriptions to the assembly and
its included CONCEPT/PROCEDURE modules. Extract the "Creating registry
storage" heading and intro sentence into a new REFERENCE module,
matching the same fix applied to the base installer-provisioned
assembly, to clear AssemblyContents. Move the registry-storage and
remote-health-monitoring cross references out of assembly-body prose
into module-level Additional resources blocks, clearing ConceptLink.

modules/installation-vsphere-multiple-nics.adoc:
- Convert the single <1> callout on the networks: field into a plain
  +-attached continuation sentence (not a where: list, since there's
  only one callout), clearing CalloutList.
- Remove a stray extra + between each ".Example configuration" title
  and its following [source,yaml] block; the extra + broke the
  title-to-block association and tripped BlockTitle even though these
  are valid code captions.

Left the Prerequisites and Next steps sections' embedded xrefs as is,
matching the AWS/GCP/Nutanix precedent of deferring that structural
pattern epic-wide, and left the pre-existing ConceptLink hit on
modules/cluster-entitlements.adoc as is, matching a prior CQA commit
that intentionally left it (see CQA-pass-criteria.md).
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 13, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 13, 2026

Copy link
Copy Markdown

@maxwelldb: This pull request references OSDOCS-17008 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

What

CQA 2.0/2.1 pre-migration pass for installing/installing_vsphere/ipi/installing-vsphere-installer-provisioned-customizations.adoc and its included modules, part of OSDOCS-17008 (vSphere IPI, under epic OSDOCS-16987 / INSTALL-6).

Changes

  • Added missing [role="_abstract"] short descriptions to the assembly and its included CONCEPT/PROCEDURE modules (installation-vsphere-regions-zones.adoc, installation-vsphere-regions-zones-host-groups.adoc, ipi-install-modifying-install-config-for-dual-stack-network.adoc, configuring-vsphere-regions-zones.adoc, configuring-vsphere-host-groups.adoc, installation-vsphere-multiple-nics.adoc, nw-operator-vsphere-multiple-subnets.adoc, ipi-install-configure-network-components-to-run-on-the-control-plane.adoc).
  • Extracted the "Creating registry storage" heading and its intro sentence into a new modules/installing-vsphere-installer-provisioned-customizations-registry-reference.adoc REFERENCE module — same fix already applied to the base installer-provisioned assembly (PR #115236) — clearing the AssemblyContents hit.
  • Moved the "Configuring the registry for vSphere" and "About remote health monitoring" cross references out of prose sentences into proper module-level .Additional resources blocks, clearing ConceptLink/RelatedLinks.
  • modules/installation-vsphere-multiple-nics.adoc:
  • Converted the single <1> callout on the networks: field into a plain +-attached continuation sentence rather than a where: list, since there's only one callout — per the single-callout rule in CQA-pass-criteria.md. Clears CalloutList.
  • Removed a stray extra + between each .Example configuration title and its following [source,yaml] block. The extra + broke the title-to-block association, so the rule flagged these as orphaned even though they're valid code captions. Clears BlockTitle.

Deliberately left as is (matches epic-wide precedent)

  • The Prerequisites and Next steps sections' embedded xrefs are unchanged, matching the AWS/GCP/Nutanix precedent documented in CQA-pass-criteria.md.
  • modules/cluster-entitlements.adoc's link:http://quay.io[Quay.io] ConceptLink hit is left as is, matching the prior CQA commit that already fixed this shared module's ShortDescription but intentionally left this link (same precedent applied in PR #115236).

Verification

  • vale --config=.vale-test.ini (AsciiDocDITA package) shows only the deferred hits above and known NoXrefInModules false positives on the properly-formed Additional resources blocks.
  • Rendered with asciidoctor -d book — clean, no structural errors, only pre-existing image-asset warnings.
  • Confirmed the callout conversion and block-title fixes render correctly (continuation sentence and .Example configuration captions both render as expected).

No technical/content meaning changed; this is a structural CQA pass only.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 13, 2026
@maxwelldb maxwelldb changed the title OSDOCS-17008: CQA 2.1 for vSphere IPI - installer-provisioned with customizations [OSDOCS#17008] CQA 2.1 for vSphere IPI - installer-provisioned with customizations Jul 13, 2026
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 13, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@maxwelldb: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

What

CQA 2.0/2.1 pre-migration pass for installing/installing_vsphere/ipi/installing-vsphere-installer-provisioned-customizations.adoc and its included modules, part of OSDOCS-17008 (vSphere IPI, under epic OSDOCS-16987 / INSTALL-6).

Changes

  • Added missing [role="_abstract"] short descriptions to the assembly and its included CONCEPT/PROCEDURE modules (installation-vsphere-regions-zones.adoc, installation-vsphere-regions-zones-host-groups.adoc, ipi-install-modifying-install-config-for-dual-stack-network.adoc, configuring-vsphere-regions-zones.adoc, configuring-vsphere-host-groups.adoc, installation-vsphere-multiple-nics.adoc, nw-operator-vsphere-multiple-subnets.adoc, ipi-install-configure-network-components-to-run-on-the-control-plane.adoc).
  • Extracted the "Creating registry storage" heading and its intro sentence into a new modules/installing-vsphere-installer-provisioned-customizations-registry-reference.adoc REFERENCE module — same fix already applied to the base installer-provisioned assembly (PR #115236) — clearing the AssemblyContents hit.
  • Moved the "Configuring the registry for vSphere" and "About remote health monitoring" cross references out of prose sentences into proper module-level .Additional resources blocks, clearing ConceptLink/RelatedLinks.
  • modules/installation-vsphere-multiple-nics.adoc:
  • Converted the single <1> callout on the networks: field into a plain +-attached continuation sentence rather than a where: list, since there's only one callout — per the single-callout rule in CQA-pass-criteria.md. Clears CalloutList.
  • Removed a stray extra + between each .Example configuration title and its following [source,yaml] block. The extra + broke the title-to-block association, so the rule flagged these as orphaned even though they're valid code captions. Clears BlockTitle.

Deliberately left as is (matches epic-wide precedent)

  • The Prerequisites and Next steps sections' embedded xrefs are unchanged, matching the AWS/GCP/Nutanix precedent documented in CQA-pass-criteria.md.
  • modules/cluster-entitlements.adoc's link:http://quay.io[Quay.io] ConceptLink hit is left as is, matching the prior CQA commit that already fixed this shared module's ShortDescription but intentionally left this link (same precedent applied in PR #115236).

Verification

  • vale --config=.vale-test.ini (AsciiDocDITA package) shows only the deferred hits above and known NoXrefInModules false positives on the properly-formed Additional resources blocks.
  • Rendered with asciidoctor -d book — clean, no structural errors, only pre-existing image-asset warnings.
  • Confirmed the callout conversion and block-title fixes render correctly (continuation sentence and .Example configuration captions both render as expected).

No technical/content meaning changed; this is a structural CQA pass only.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@maxwelldb maxwelldb changed the title [OSDOCS#17008] CQA 2.1 for vSphere IPI - installer-provisioned with customizations [OSDOCS-17008] CQA 2.1 for vSphere IPI installer-provisioned with customizations Jul 13, 2026
@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown

@maxwelldb: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maxwelldb maxwelldb changed the title [OSDOCS-17008] CQA 2.1 for vSphere IPI installer-provisioned with customizations [OSDOCS#17008] CQA 2.1 for vSphere IPI installer-provisioned with customizations Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants