Skip to content

[RHACS] [Docs] [rhacs-docs-main] ROX-33164: Fixing DITA errors in cloud_service/upgrading-cloud/upgrade-cloudsvc-helm.adoc - #112137

Merged
agantony merged 1 commit into
openshift:rhacs-docs-mainfrom
agantony:ROX33164-dita-rework-upgrade-cloudsvc-helm
Aug 31, 2026
Merged

[RHACS] [Docs] [rhacs-docs-main] ROX-33164: Fixing DITA errors in cloud_service/upgrading-cloud/upgrade-cloudsvc-helm.adoc#112137
agantony merged 1 commit into
openshift:rhacs-docs-mainfrom
agantony:ROX33164-dita-rework-upgrade-cloudsvc-helm

Conversation

@agantony

Copy link
Copy Markdown
Contributor

Version(s):
4.9+

Issue:
https://redhat.atlassian.net/browse/ROX-33164

Link to docs preview:

SME review: NA

Additional information:

  • Cherrypick to:
    • rhacs-docs-4.10
    • rhacs-docs-4.9

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 22, 2026
@openshift-ci-robot

openshift-ci-robot commented May 22, 2026

Copy link
Copy Markdown

@agantony: This pull request references ROX-33164 which is a valid jira issue.

Details

In response to this:

Version(s):
4.9+

Issue:
https://redhat.atlassian.net/browse/ROX-33164

Link to docs preview:

SME review: NA

Additional information:

  • Cherrypick to:
    • rhacs-docs-4.10
    • rhacs-docs-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony agantony added RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.9 rhacs-docs-4.10 and removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 22, 2026
@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2026
@ocpdocs-previewbot

Copy link
Copy Markdown

@openshift-ci

openshift-ci Bot commented May 22, 2026

Copy link
Copy Markdown

@agantony: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@agantony

Copy link
Copy Markdown
Contributor Author

PR Review Summary

Changes Made

This PR addresses a minor DITA compliance issue in the cloud service Helm upgrade documentation. The change corrects an Asciidoc syntax error in a module reference.

Scope: 1 file modified (1 module)

  • DITA compliance: Attribute reference syntax correction
  • Line count: +1 line added, -1 line removed

Summary of Changes

File Location Changes Before/After
modules/upgrade-helm-chart.adoc Procedure module Fixed attribute reference syntax from {$product-title} to {product-title-short} 1 line modified

Key change:

  • Corrected invalid attribute reference that included $ symbol (shell variable syntax)
  • Replaced with proper Asciidoc attribute reference without $ prefix
  • Changed to use product-title-short attribute for consistency

Navigation Guide - Review Changes

Step 1: Review Helm Upgrade Procedure

  • Open: Upgrade using Helm
  • Verify: Product title renders correctly in step content
  • Check: No attribute placeholder text visible (like {product-title-short})

Step 2: Verify Attribute Resolution

  • Location: Within upgrade procedure steps
  • Verify: Product name appears as expected text (e.g., "RHACS" or full product name)
  • Check: No broken attribute references or rendering issues

Verification Checklists

Structural Verification

  • Asciidoc attribute syntax is correct
  • Attribute reference resolves properly
  • No unintended attribute changes

Content Verification

  • Product title displays correctly
  • Step content remains technically accurate
  • No impact to procedure clarity

DITA Compliance Verification

  • Attribute reference follows Asciidoc standards
  • Syntax compatible with DITA conversion toolchain
  • No shell variable syntax (e.g., $) in attributes

Quick Visual Review Guide

Key elements to check in Netlify preview:

  1. Attribute rendering: Product title appears as text, not attribute placeholder
  2. Content accuracy: Procedure steps reference correct product name
  3. No errors: No visible parsing errors or malformed content

@jlprevatt jlprevatt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agantony
agantony merged commit 764acb2 into openshift:rhacs-docs-main Aug 31, 2026
2 checks passed
@agantony

Copy link
Copy Markdown
Contributor Author

/cherrypick rhacs-docs-4.11

@agantony

Copy link
Copy Markdown
Contributor Author

/cherrypick rhacs-docs-4.10

@openshift-cherrypick-robot

Copy link
Copy Markdown

@agantony: new pull request created: #119028

Details

In response to this:

/cherrypick rhacs-docs-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@agantony: new pull request created: #119029

Details

In response to this:

/cherrypick rhacs-docs-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.9 rhacs-docs-4.10 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants