accept risks e2e becomes blocking

[hongkailiu]

As June 4, 2026, the passing rate in Sippy is

The failure looks similar to this one:

started: 1/34/46 "[sig-cli][OCPFeatureGate:ClusterUpdateAcceptRisks] oc can operate accept risks [Serial]"

Running 'oc --kubeconfig=/tmp/kubeconfig-4043812754 get configmap microshift-version -n kube-public -o jsonpath={.data.version}'
ERROR: Command failed with error: exit status 1
Output: Error from server (NotFound): configmaps "microshift-version" not found

  [FAILED] in [BeforeEach] - /go/src/github.com/openshift/oc/test/e2e/accept.go:39 @ 06/04/26 06:13:14.427
  [FAILED] in [AfterEach] - /go/src/github.com/openshift/oc/test/e2e/accept.go:57 @ 06/04/26 06:13:14.53

fail [github.com/openshift/oc/test/e2e/accept.go:39]: Expected
    <[]v1.AcceptRisk | len:1, cap:1>: [
        {
            Name: "TestAlertFeatureE2ETestOTA1813",
        },
    ]
to be empty
failed: (400ms) 2026-06-04T06:13:14 "[sig-cli][OCPFeatureGate:ClusterUpdateAcceptRisks] oc can operate accept risks [Serial]"

It is because the cleanup in the previous test cases failed

started: 0/1/46 "[Jira:\"Cluster Version Operator\"] cluster-version-operator should work with risks from alerts"

  STEP: Using fauxinnati as the upstream and its simple channel @ 06/04/26 05:38:40.344
  STEP: Create a critical alert for testing @ 06/04/26 05:38:40.387
  STEP: Checking if the risk shows up in ClusterVersion's status @ 06/04/26 05:38:40.443
  STEP: Checking that no updates is recommended if alert is firing @ 06/04/26 05:39:10.474
  STEP: Checking that there are recommended conditional updates promoted to available updates after the risk from alert is accepted @ 06/04/26 05:39:10.508
  STEP: Checking that there are no duplicated versions in conditional updates @ 06/04/26 05:39:40.642
  STEP: Checking that there are no duplicated versions in available updates @ 06/04/26 05:39:40.671
  STEP: Checking that there are no recommended conditional updates after the alert is resolved @ 06/04/26 05:39:40.673
  STEP: Checking that there are available updates after the alert is resolved @ 06/04/26 05:40:40.737
  [FAILED] in [AfterEach] - /go/src/github.com/openshift/cluster-version-operator/test/cvo/accept_risks.go:79 @ 06/04/26 05:40:40.824

fail [github.com/openshift/cluster-version-operator/test/cvo/accept_risks.go:79]: Unexpected error:
    <*errors.StatusError | 0xc0004d0c80>: 
    Operation cannot be fulfilled on clusterversions.config.openshift.io "version": the object has been modified; please apply your changes to the latest version and try again
    {
        ErrStatus: {
            TypeMeta: {Kind: "", APIVersion: ""},
            ListMeta: {
                SelfLink: "",
                ResourceVersion: "",
                Continue: "",
                RemainingItemCount: nil,
            },
            Status: "Failure",
            Message: "Operation cannot be fulfilled on clusterversions.config.openshift.io \"version\": the object has been modified; please apply your changes to the latest version and try again",
            Reason: "Conflict",
            Details: {
                Name: "version",
                Group: "config.openshift.io",
                Kind: "clusterversions",
                UID: "",
                Causes: nil,
                RetryAfterSeconds: 0,
            },
            Code: 409,
        },
    }
occurred
failed: (2m1s) 2026-06-04T05:40:40 "[Jira:\"Cluster Version Operator\"] cluster-version-operator should work with risks from alerts"

We hope that openshift/cluster-version-operator#1399 will help. Let us review the stats again after a while.

/hold

Summary by CodeRabbit

• Tests

  • Simplified a cluster update acceptance test by removing an unnecessary test option and streamlining its labels.

• Chores

  • Cleaned up redundant test code and removed unused test dependencies.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4f7b2c91-0135-4160-81a9-41704d1b6f82

📥 Commits

Reviewing files that changed from the base of the PR and between ba02b6e and 17d7929.

📒 Files selected for processing (1)

• test/e2e/accept.go

---

Walkthrough

The PR removes the oteginkgo.Informing() option from a test case definition and removes the corresponding unused import from test/e2e/accept.go.

Changes

Test case cleanup

Layer / File(s)	Summary
Remove unused Informing option and import test/e2e/accept.go	Removed oteginkgo import and updated the [sig-cli][OCPFeatureGate:ClusterUpdateAcceptRisks] serial tech-preview test case to remove the oteginkgo.Informing() option.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	Violates quality requirements: (1) Tests 5 scenarios in single It block; (2) Uses context.TODO() with no timeout on cluster API calls; (3) Missing assertion failure messages.	Add context timeouts via wait.Poll/WithTimeout, split into separate tests, add failure messages to all Expect calls.
Title check	❓ Inconclusive	The title 'accept risks e2e becomes blocking' is vague and does not clearly convey what change was made. The actual change is removing the 'Informing' option from a test case, but the title suggests a different action.	Clarify the title to specifically describe the change, such as 'Remove Informing option from accept risks e2e test' or 'Make accept risks e2e test non-informing'.

✅ Passed checks (13 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All test names in test/e2e/accept.go are stable and deterministic with no dynamic information, generated suffixes, timestamps, UUIDs, or node/namespace names.
Microshift Test Compatibility	✅ Passed	Test uses config.openshift.io ClusterVersion API unavailable on MicroShift, but is protected by skipIfMicroShift() in BeforeEach that calls g.Skip(), satisfying check requirements.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Test only manipulates ClusterVersion API (available on SNO), performs no multi-node operations, and already calls skipIfMicroShift() for platform compatibility checks.
Topology-Aware Scheduling Compatibility	✅ Passed	PR changes only test files (test/e2e/accept.go), build scripts, and Dockerfile versions. No deployment manifests, operator code, or scheduling constraints introduced.
Ote Binary Stdout Contract	✅ Passed	The modified test/e2e/accept.go file contains no stdout writes in process-level code. All logging correctly uses GinkgoWriter. klog calls are only in error handlers, not initialization.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Test makes no IPv4 assumptions or hardcoded IPs, uses cluster-internal APIs only (kubeconfig, ConfigV1Client), no external connectivity required, no IPv6 incompatibilities detected.
No-Weak-Crypto	✅ Passed	The PR modifies only test/e2e/accept.go, a test configuration file with no cryptographic operations, weak cipher usage, custom crypto implementations, or insecure secret comparisons.
Container-Privileges	✅ Passed	PR modifies only a Go test file (test/e2e/accept.go) with no container manifests or Kubernetes security configurations that would require privilege escalation checks.
No-Sensitive-Data-In-Logs	✅ Passed	PR removes test framework label only. Test logs non-sensitive data: paths, risk names, command output. No passwords, tokens, API keys, or PII are exposed.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hongkailiu]

/test e2e-agnostic-ovn-cmd

[openshift-ci]

@hongkailiu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.