Skip to content

Add CI plugin image substitution guide and developer comments - #2345

Closed
kaovilai wants to merge 1 commit into
openshift:oadp-1.6from
redhat-chai-bot:ci-image-substitution-docs
Closed

Add CI plugin image substitution guide and developer comments#2345
kaovilai wants to merge 1 commit into
openshift:oadp-1.6from
redhat-chai-bot:ci-image-substitution-docs

Conversation

@kaovilai

Copy link
Copy Markdown
Member

Adds CI plugin image substitution documentation: Go comments in common.go plus a new docs/ci-plugin-image-sync.md guide, explaining how the openshift/release CI image substitutions (companion PR) map to plugin builds.

Note

Proposed by chai-bot (redhat-chai-bot), opened as draft via Claude Code.

When a new plugin image is added to OADP, the corresponding
ci-operator configs in openshift/release must also be updated with
base_images and operator.substitutions entries so that CI e2e tests
use freshly promoted images instead of stale quay.io mirrors.

Add a Go comment block above the Images const in pkg/common/common.go
explaining the requirement, and create docs/ci-plugin-image-sync.md
with the full step-by-step procedure and a concrete example.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cb816a64-3b0a-4e07-9dbf-bb1b5933aba0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026
@kaovilai

Copy link
Copy Markdown
Member Author

/close

@openshift-ci openshift-ci Bot closed this Jul 31, 2026
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

@kaovilai: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kaovilai

Copy link
Copy Markdown
Member Author

Superseded by #2346 — same doc content, but scoped to just the common.go comment block (no docs/ file, no config/manager/manager.yaml changes), correctly targeting oadp-dev. Closing this one.

Note

Responses generated with Claude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants