Skip to content

NO-JIRA: Update OWNERS file - #185

Open
maayanf24 wants to merge 1 commit into
openshift:mainfrom
maayanf24:update-owners
Open

NO-JIRA: Update OWNERS file#185
maayanf24 wants to merge 1 commit into
openshift:mainfrom
maayanf24:update-owners

Conversation

@maayanf24

@maayanf24 maayanf24 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Remove martinkennelly from reviewers list

Summary by CodeRabbit

  • Chores
    • Updated code review settings by adjusting the default reviewer list.
    • Updated code approval settings by revising the approver list.

No end-user behavior changes.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci
openshift-ci Bot requested review from mattedallo and tssurya July 9, 2026 13:56
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Walkthrough

The OWNERS file was updated by removing two reviewers and two approvers from their respective lists. No other metadata entries were changed.

Changes

OWNERS metadata

Layer / File(s) Summary
Update reviewer and approver lists
OWNERS
Removed martinkennelly and pliurh from reviewers, and pliurh and zshi-redhat from approvers.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only OWNERS changed; no Ginkgo tests or titles were added/edited, so the check is not applicable.
Test Structure And Quality ✅ Passed Only OWNERS changed; no Ginkgo test code or test behavior was modified, so this check is not applicable.
Microshift Test Compatibility ✅ Passed Only OWNERS changed in 67969fd; no tests or Ginkgo specs were added, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only OWNERS changed; no Ginkgo tests were added or modified, so there are no SNO-compatibility concerns to flag.
Topology-Aware Scheduling Compatibility ✅ Passed Only OWNERS metadata changed; no deployment manifests, operator code, or controllers were modified, so no topology-aware scheduling impact.
Ote Binary Stdout Contract ✅ Passed PASS — PR only changes OWNERS ownership metadata; no process-level code or stdout-writing paths were modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only OWNERS changed; no Ginkgo e2e tests or network-sensitive code were added, so the IPv6/disconnected-network check is not applicable.
No-Weak-Crypto ✅ Passed PR only changes OWNERS metadata; no code or crypto-related files/functions were modified, so no weak-crypto issue is introduced.
Container-Privileges ✅ Passed Only OWNERS changed; no container/K8s manifests or privilege settings were touched.
No-Sensitive-Data-In-Logs ✅ Passed Only OWNERS reviewers/approvers changed; no code, log statements, or sensitive-data handling was modified.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change to the OWNERS file.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread OWNERS Outdated
Comment thread OWNERS Outdated
Remove martinkennelly, zshi-redhat, pliurh
from reviewers & approvers list

Signed-off-by: Maayan Friedman <maafried@redhat.com>
@mattedallo

Copy link
Copy Markdown

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-ovn

@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maayanf24, mattedallo
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maayanf24, mattedallo
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@maayanf24: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maayanf24

Copy link
Copy Markdown
Contributor Author

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 4, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@maayanf24: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@maayanf24 maayanf24 changed the title Update OWNERS file NO-JIRA: Update OWNERS file Aug 4, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 4, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@maayanf24: This pull request explicitly references no jira issue.

Details

In response to this:

Remove martinkennelly from reviewers list

Summary by CodeRabbit

  • Chores
  • Updated code review settings by adjusting the default reviewer list.
  • Updated code approval settings by revising the approver list.

No end-user behavior changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants