[release-4.22]AGENT-1548: Backport NoRegistryClusterInstall feature to release-4.22

[bfournie]

Backport the following PRs:
#5765
#5721
#6003
#6041
#6070
#5988
#5841
#6100
#6109
#6146
#6145
#6159
#6280

- What I did

- How to verify it

- Description for the changelog

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@bfournie: This pull request references AGENT-1500 which is a valid jira issue.

Details

In response to this:

Backport the following PRs:
#5765
#5721
#6003
#6041
#6070
#5988
#5841
#6100
#6109
#6146
#6145
#6159
#6280

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 51ef5107-8e9c-4ffe-b045-7aff932f9446

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@bfournie: This pull request references AGENT-1548 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Backport the following PRs:
#5765
#5721
#6003
#6041
#6070
#5988
#5841
#6100
#6109
#6146
#6145
#6159
#6280

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bfournie]

/jira refresh

[openshift-ci-robot]

@bfournie: This pull request references AGENT-1548 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bfournie]

/test unit

[bfournie]

/test unit
Looks like a flake unrelated to the changes.

[bfournie]

/test unit

[bfournie]

/test unit

[bfournie]

/test ?

[bfournie]

/test e2e-agent-compact-ipv4-iso-no-registry

[bfournie]

/test e2e-agent-compact-ipv4-iso-no-registry

[bfournie]

/test e2e-agent-compact-ipv4-iso-no-registry

[bfournie]

@ptalgulk01 I updated the PR so those jobs may need to be deployed again. Thank you.

[bfournie]

/test e2e-agent-compact-ipv4-iso-no-registry

[ptalgulk01]

new deployed job
Job: aws-fips-longduration-1of3
URL: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-fips-proxy-longduration-1of3/2082034792009830400
Job: aws-fips-longduration-2of3
URL: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-fips-proxy-longduration-2of3/2082034804135563264
Job: aws-fips-longduration-3of3
URL: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-fips-proxy-longduration-3of3/2082034812469645312
Job: vsphere-tp-longduration-1of2
URL: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-tp-longduration-1of2/2082034827795632128
Job: vsphere-tp-longduration-2of2
URL: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-tp-longduration-2of2/2082034842433753088

[andfasano]

Logically seems fine - I think this is only "missing" #6119 - would probably be nice to have.
If both core MCO tests are fine, and it's passing your install job, this should be safe to merge

Good idea, added #6119. Would you be able to add the backport-risk-assessed label and also set the jira/valid-bug since this is using an SBAR and not OCPBUGS? Thanks.

cc @yuqi-zhang

[bfournie]

/verified by ci/prow/e2e-agent-compact-ipv4-iso-no-registry

[openshift-ci-robot]

@bfournie: This PR has been marked as verified by ci/prow/e2e-agent-compact-ipv4-iso-no-registry.

Details

In response to this:

/verified by ci/prow/e2e-agent-compact-ipv4-iso-no-registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bfournie]

/test unit

[zaneb]

Manually adding valid-bug as this is subject to an approved SBAR.

[bfournie]

Note that the unit test is failing on TestOSBuildController/MachineConfig, this appears to be a pre-existing flaky test unrelated to this PR. The test has a race condition where the reconciler processes a job's "Succeeded" status before the digest configmap is visible, causing configmaps "digest-..." not found and a context deadline timeout.

Earlier PRs like this had the exact same failure (same test, same error, same root cause) and passed on retest but I can't seem to get this to pass on retest.

It looks like there were earlier changes example to mitigate this particular failure.

[pablintino]

Hey @ptalgulk01, care to review the longduration results? If all is fine from our side I'll let this change go.

[ptalgulk01]

Hey @ptalgulk01, care to review the longduration results? If all is fine from our side I'll let this change go.

There is timeout due to which job were not completed I had triggered this jobs

• aws-fips-1of3: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-fips-proxy-longduration-1of3/2082367296185044992
• aws-fips-2of3: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-fips-proxy-longduration-2of3/2082367399423643648
• aws-fips-3of3: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-fips-proxy-longduration-3of3/2082367822968655872
• vsphere-tp-1of2: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-tp-longduration-1of2/2082368063214194688
• vsphere-tp-2of2: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-tp-longduration-2of2/2082367311045464064

[ptalgulk01]

No issues seen from MCO side, and the TC failed are failing from previously.

[pablintino]

/test unit
/lgtm
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, bfournie, pablintino, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [pablintino,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 0f69adf and 2 for PR HEAD eb98061 in total

[openshift-ci]

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.