Skip to content

NO-ISSUE: Bump github.com/InVisionApp/go-health to v2.1.4 - #6281

Open
skitt wants to merge 1 commit into
openshift:mainfrom
skitt:go-health-v2
Open

NO-ISSUE: Bump github.com/InVisionApp/go-health to v2.1.4#6281
skitt wants to merge 1 commit into
openshift:mainfrom
skitt:go-health-v2

Conversation

@skitt

@skitt skitt commented Jul 7, 2026

Copy link
Copy Markdown
Member

- What I did

I noticed that github.com/InVisionApp/go-health is outdated and that the latest versions are Go modules. (The project has since been archivde though.)

- How to verify it

- Description for the changelog

Bump github.com/InVisionApp/go-health to v2.1.4

Summary by CodeRabbit

  • Chores
    • Updated health-check library dependency to a newer version for improved long-term compatibility and maintenance support.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@skitt: This pull request explicitly references no jira issue.

Details

In response to this:

- What I did

I noticed that github.com/InVisionApp/go-health is outdated and that the latest versions are Go modules. (The project has since been archivde though.)

- How to verify it

- Description for the changelog

Bump github.com/InVisionApp/go-health to v2.1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Walkthrough

This PR updates the apiserver-watcher health-check imports and Go module requirement to go-health v2.1.4. It also removes an indirect go-sqlmock dependency.

Changes

go-health v2 migration

Layer / File(s) Summary
Update health-check dependency
go.mod, cmd/apiserver-watcher/run.go
The module requirement and health-check imports use go-health v2.1.4. The indirect go-sqlmock.v1 requirement is removed.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: djoshy, harshwardhanpatil07

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the dependency update to github.com/InVisionApp/go-health v2.1.4.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes no *_test.go files, and searches found no Ginkgo title calls in changed Go files; the patch only updates dependency imports and vendored metadata.
Test Structure And Quality ✅ Passed The patch changes only health imports, dependency metadata, and vendored files; it adds or modifies no *_test.go files or Ginkgo test code.
Microshift Test Compatibility ✅ Passed No Ginkgo e2e tests or test files were added; the diff only updates imports, module metadata, and vendored go-health code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR updates a Go module dependency without adding new Ginkgo e2e tests. The check is not applicable since it targets only new test additions.
Topology-Aware Scheduling Compatibility ✅ Passed The patch changes health-check imports, module metadata, checksums, and vendored dependency files only; it adds no deployment, operator, controller, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR only updates go-health import paths; no process-level code changes that write to stdout. Existing klog is configured to use stderr via flag.Set("logtostderr", "true").
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only dependency imports, module metadata, checksums, and vendored files; it adds or modifies no Ginkgo e2e tests.
No-Weak-Crypto ✅ Passed The pull request updates go-health import paths and dependency version without introducing any weak cryptographic algorithms, custom crypto implementations, or insecure secret comparisons.
Container-Privileges ✅ Passed The PR changes Go imports, dependency metadata, and vendored library files only; no container or Kubernetes manifest adds a listed privilege setting.
No-Sensitive-Data-In-Logs ✅ Passed Pull request only upgrades go-health dependency version with no code logic changes or new logging statements that expose sensitive data like passwords, tokens, or API keys.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skitt
Once this PR has been reviewed and has the lgtm label, please assign proietfb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@isabella-janssen

Copy link
Copy Markdown
Member

/hold

Holding to allow the Kube rebase to land in #6321. Please ensure this will not cause merge conflicts for the Kube rebase before unholding this PR.

@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 28, 2026
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
go.mod (1)

8-8: 🔒 Security & Privacy | 🔵 Trivial | 🏗️ Heavy lift

Track a replacement for the archived dependency.

v2.1.4 is the latest release, but the upstream repository was archived on December 23, 2024. Treat this as a temporary exception and link a migration issue with an owner before relying on it for future security fixes. (github.com)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 8, Add a temporary exception comment next to the
github.com/InVisionApp/go-health/v2 dependency documenting that the upstream is
archived, and include a link to a migration issue with an assigned owner. Track
and reference the replacement plan while retaining version v2.1.4 until
migration is completed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@go.mod`:
- Line 8: Add a temporary exception comment next to the
github.com/InVisionApp/go-health/v2 dependency documenting that the upstream is
archived, and include a link to a migration issue with an assigned owner. Track
and reference the replacement plan while retaining version v2.1.4 until
migration is completed.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5039cc67-9981-4a9d-9906-9bf11f2ff6c1

📥 Commits

Reviewing files that changed from the base of the PR and between 777892a and ab3bbc2.

⛔ Files ignored due to path filters (16)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/InVisionApp/go-health/.travis.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/in-repo.yaml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/CODEOWNERS is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/Makefile is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/checkers/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/checkers/http.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/checkers/reachable.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/checkers/sql.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/health.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/in-repo.yaml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/safe.go is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (2)
  • cmd/apiserver-watcher/run.go
  • go.mod

@isabella-janssen

isabella-janssen commented Jul 29, 2026

Copy link
Copy Markdown
Member

/unhold

Kube rebase landed

@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 29, 2026
This is now a Go module.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
go.mod (1)

60-60: 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

Upgrade google.golang.org/grpc to v1.82.1 or later.

OSV and the upstream advisory list the declared and vendored v1.79.3 as affected by GHSA-hrxh-6v49-42gf (GO-2026-6061). MCO uses gRPC clients only and does not use xDS RBAC or expose a gRPC server. Update go.mod, go.sum, and the vendor tree.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 60, Upgrade the google.golang.org/grpc dependency from
v1.79.3 to v1.82.1 or later, then regenerate go.sum and the vendor tree so all
declared, checksummed, and vendored gRPC artifacts match the new version.

Sources: Path instructions, Linters/SAST tools

🧹 Nitpick comments (1)
go.mod (1)

222-222: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Upgrade go.opentelemetry.io/otel/sdk to v1.43.0 or later if BSD or Solaris builds are supported. OSV lists v1.40.0 as affected by GHSA-hfvc-g4fc-pqhx / GO-2026-5426. Current repository builds target Linux, where the vulnerable kenv path is excluded.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 222, Update the go.opentelemetry.io/otel/sdk indirect
dependency from v1.40.0 to v1.43.0 or later when BSD or Solaris builds are
supported, while preserving the existing dependency configuration for Linux-only
builds.

Sources: Path instructions, Linters/SAST tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@go.mod`:
- Line 60: Upgrade the google.golang.org/grpc dependency from v1.79.3 to v1.82.1
or later, then regenerate go.sum and the vendor tree so all declared,
checksummed, and vendored gRPC artifacts match the new version.

---

Nitpick comments:
In `@go.mod`:
- Line 222: Update the go.opentelemetry.io/otel/sdk indirect dependency from
v1.40.0 to v1.43.0 or later when BSD or Solaris builds are supported, while
preserving the existing dependency configuration for Linux-only builds.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 31390322-8867-457c-95d9-23efd980b95d

📥 Commits

Reviewing files that changed from the base of the PR and between ab3bbc2 and 42ead2a.

⛔ Files ignored due to path filters (15)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/InVisionApp/go-health/.travis.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/in-repo.yaml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/CODEOWNERS is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/Makefile is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/checkers/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/checkers/http.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/checkers/reachable.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/checkers/sql.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/health.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/in-repo.yaml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/safe.go is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (2)
  • cmd/apiserver-watcher/run.go
  • go.mod
🚧 Files skipped from review as they are similar to previous changes (1)
  • cmd/apiserver-watcher/run.go

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@skitt: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants