NO-ISSUE: Bump github.com/InVisionApp/go-health to v2.1.4 - #6281
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@skitt: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis PR updates the apiserver-watcher health-check imports and Go module requirement to go-health v2.1.4. It also removes an indirect go-sqlmock dependency. Changesgo-health v2 migration
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: skitt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold Holding to allow the Kube rebase to land in #6321. Please ensure this will not cause merge conflicts for the Kube rebase before unholding this PR. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
go.mod (1)
8-8: 🔒 Security & Privacy | 🔵 Trivial | 🏗️ Heavy liftTrack a replacement for the archived dependency.
v2.1.4is the latest release, but the upstream repository was archived on December 23, 2024. Treat this as a temporary exception and link a migration issue with an owner before relying on it for future security fixes. (github.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` at line 8, Add a temporary exception comment next to the github.com/InVisionApp/go-health/v2 dependency documenting that the upstream is archived, and include a link to a migration issue with an assigned owner. Track and reference the replacement plan while retaining version v2.1.4 until migration is completed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@go.mod`:
- Line 8: Add a temporary exception comment next to the
github.com/InVisionApp/go-health/v2 dependency documenting that the upstream is
archived, and include a link to a migration issue with an assigned owner. Track
and reference the replacement plan while retaining version v2.1.4 until
migration is completed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 5039cc67-9981-4a9d-9906-9bf11f2ff6c1
⛔ Files ignored due to path filters (16)
go.sumis excluded by!**/*.sumvendor/github.com/InVisionApp/go-health/.travis.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/in-repo.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/CODEOWNERSis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/Makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/checkers/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/checkers/http.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/checkers/reachable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/checkers/sql.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/health.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/in-repo.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/safe.gois excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (2)
cmd/apiserver-watcher/run.gogo.mod
|
/unhold Kube rebase landed |
This is now a Go module. Signed-off-by: Stephen Kitt <skitt@redhat.com>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
go.mod (1)
60-60: 🔒 Security & Privacy | 🟠 Major | ⚡ Quick winUpgrade
google.golang.org/grpctov1.82.1or later.OSV and the upstream advisory list the declared and vendored
v1.79.3as affected byGHSA-hrxh-6v49-42gf(GO-2026-6061). MCO uses gRPC clients only and does not use xDS RBAC or expose a gRPC server. Updatego.mod,go.sum, and the vendor tree.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` at line 60, Upgrade the google.golang.org/grpc dependency from v1.79.3 to v1.82.1 or later, then regenerate go.sum and the vendor tree so all declared, checksummed, and vendored gRPC artifacts match the new version.Sources: Path instructions, Linters/SAST tools
🧹 Nitpick comments (1)
go.mod (1)
222-222: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winUpgrade
go.opentelemetry.io/otel/sdkto v1.43.0 or later if BSD or Solaris builds are supported. OSV lists v1.40.0 as affected by GHSA-hfvc-g4fc-pqhx / GO-2026-5426. Current repository builds target Linux, where the vulnerablekenvpath is excluded.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` at line 222, Update the go.opentelemetry.io/otel/sdk indirect dependency from v1.40.0 to v1.43.0 or later when BSD or Solaris builds are supported, while preserving the existing dependency configuration for Linux-only builds.Sources: Path instructions, Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@go.mod`:
- Line 60: Upgrade the google.golang.org/grpc dependency from v1.79.3 to v1.82.1
or later, then regenerate go.sum and the vendor tree so all declared,
checksummed, and vendored gRPC artifacts match the new version.
---
Nitpick comments:
In `@go.mod`:
- Line 222: Update the go.opentelemetry.io/otel/sdk indirect dependency from
v1.40.0 to v1.43.0 or later when BSD or Solaris builds are supported, while
preserving the existing dependency configuration for Linux-only builds.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 31390322-8867-457c-95d9-23efd980b95d
⛔ Files ignored due to path filters (15)
go.sumis excluded by!**/*.sumvendor/github.com/InVisionApp/go-health/.travis.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/in-repo.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/CODEOWNERSis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/Makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/checkers/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/checkers/http.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/checkers/reachable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/checkers/sql.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/health.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/in-repo.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/safe.gois excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (2)
cmd/apiserver-watcher/run.gogo.mod
🚧 Files skipped from review as they are similar to previous changes (1)
- cmd/apiserver-watcher/run.go
|
@skitt: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- What I did
I noticed that github.com/InVisionApp/go-health is outdated and that the latest versions are Go modules. (The project has since been archivde though.)
- How to verify it
- Description for the changelog
Bump github.com/InVisionApp/go-health to v2.1.4
Summary by CodeRabbit