[release-4.19] NO-ISSUE: Add memory limit to machine-controller container

[perdasilva]

Cherry-pick of #1503 to release-4.19.

Summary

• Add a 512Mi memory limit to the machine-controller container as a safety net against unbounded memory growth from leaked AWS session HTTP transports
• Only the machine-controller container is affected — other controllers (machineset, healthcheck, nodelink) keep the existing resource spec without a limit
• Companion fix in machine-api-provider-aws: openshift/machine-api-provider-aws#190

Test Plan

• make unit passes with race detector (13 suites)
• make vet and gofmt clean
• Unit test: machine-controller has 512Mi memory limit
• Unit test: machine-controller has 20Mi memory request (unchanged)
• Unit test: other controllers have no memory limit

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: eaee8f53-5f6b-40be-85b0-06c47e26455f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@perdasilva: This pull request explicitly references no jira issue.

Details

In response to this:

Set a 512Mi memory limit on the machine-controller container as a safety net against unbounded memory growth from leaked AWS session transports. Other controllers are unaffected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[perdasilva]

/hold testing

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@perdasilva: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/goimports	da6ebd2	link	true	/test goimports

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.