Update k8s.io/kube-openapi digest to 865597e#1583
Conversation
|
/hold Revision bafe91f was retested 3 times: holding |
bafe91f to
9b07c36
Compare
|
New changes are detected. LGTM label has been removed. |
9b07c36 to
d0a0b88
Compare
d0a0b88 to
a1f3d08
Compare
a1f3d08 to
5b0066d
Compare
5b0066d to
5b456f3
Compare
16d37a7 to
e576faf
Compare
09543e2 to
2bb82e3
Compare
2bb82e3 to
c04f4c7
Compare
c04f4c7 to
0f0c65c
Compare
0f0c65c to
ebbb52a
Compare
ebbb52a to
bc491a3
Compare
bc491a3 to
e48a54b
Compare
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
e48a54b to
5f9b68e
Compare
📝 WalkthroughWalkthroughThe pull request updates the indirect dependency ChangesDependency Update
🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 167: go.mod pins k8s.io/kube-openapi at commit 865597e52e25 which is out
of sync with the other Kubernetes modules (k8s.io/api, k8s.io/apimachinery,
k8s.io/client-go) at v0.35.4; update the k8s.io/kube-openapi entry to the
version Kubernetes v0.35.4 expects (v0.0.0-20250910181357-589584f1c912) or,
alternatively, bump all Kubernetes-related modules together to a consistent
release; modify the k8s.io/kube-openapi module version string in go.mod (the
k8s.io/kube-openapi line) so it matches the chosen approach and then run go mod
tidy to regenerate go.sum and ensure module graph consistency.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 46b81498-0ee8-417e-83bb-6f759e7de298
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum,!go.sum
📒 Files selected for processing (1)
go.mod
| k8s.io/apiextensions-apiserver v0.35.4 // indirect | ||
| k8s.io/klog/v2 v2.140.0 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20260427204847-8949caaa1199 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20260603220949-865597e52e25 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check for security advisories for k8s.io/kube-openapi
# Check for GitHub security advisories
gh api graphql -f query='
{
securityVulnerabilities(first: 10, ecosystem: GO, package: "k8s.io/kube-openapi") {
nodes {
advisory {
summary
severity
publishedAt
}
vulnerableVersionRange
firstPatchedVersion {
identifier
}
}
}
}'
# Verify the commit exists in the repository
echo "Checking if commit 865597e52e25 exists..."
gh api repos/kubernetes/kube-openapi/commits/865597e52e25 --jq '.sha, .commit.author.date, .commit.message' 2>&1Repository: openshift/lightspeed-operator
Length of output: 371
🌐 Web query:
k8s.io/kube-openapi commit 865597e52e25 changelog security
💡 Result:
I couldn’t locate any source that ties the specific kube-openapi commit 865597e52e25 to a changelog entry or a security fix. What I did find: a recent kube-openapi update in Kubernetes that mentions “key changes upstream” (including an escaping bugfix for JSON-Pointer-reserved characters in generated schema/component names) in PR #138741, but that PR’s referenced kube-openapi revision is b7f5293f4787—not 865597e52e25—and the snippets available don’t mention security implications. Security-related material I found for kube-openapi is general (e.g., the repo’s SECURITY.md and an OpenAPI V3 security requirements PR), but it’s not associated with commit 865597e52e25. So, based on the evidence available from the searches, I can’t confidently answer what security/changelog item 865597e52e25 corresponds to. If you can share the full 40-char commit hash (or a link to the commit/compare view), I can try again and specifically map it to the relevant kube-openapi changelog/security note(s).
Citations:
- 1: bump k8s.io/kube-openapi to v0.0.0-20260502001324-b7f5293f4787 kubernetes/kubernetes#138741
- 2: Add repo SECURITY.md kubernetes/kube-openapi#199
- 3: Add security requirement to root OpenAPI V3 kubernetes/kube-openapi#432
- 4: https://github.com/kubernetes/kube-openapi/tree/ee342a809c29ce286ab48cea8442ef9cd0ab8c1c
🌐 Web query:
k8s.io/kube-openapi compatibility with kubernetes 0.35.4
💡 Result:
For Kubernetes v0.35.4, compatibility is achieved by using the kube-openapi version that Kubernetes itself vendors/depends on for that release. In the v0.35.4 line, the kube-apiserver (and related components) depend on k8s.io/kube-openapi at v0.0.0-20250910181357-589584f1c912 [1][2]. In other words: kube-openapi is not “version-compatible” across arbitrary Kubernetes versions; you should align kube-openapi to the Kubernetes release’s expected module version (above) to avoid OpenAPI generation/aggregation mismatches. What this means in practice 1) If you are building extension API servers or clients: match kube-openapi to the Kubernetes branch/release you’re targeting (for k8s 0.35.4, use the kube-openapi commit/version listed above) [1][2]. 2) If you mix versions (kube-openapi newer/older than what kube-apiserver expects), you can hit OpenAPI backward-incompatibility issues—e.g., kube-openapi changes around how model names are generated for OpenAPI v2 aggregation can be backward-incompatible and require Kubernetes-side bumps / kube-openapi bumps [3][4]. Source-backed anchor for Kubernetes OpenAPI generation The kube-apiserver’s OpenAPI handler imports kube-openapi packages (k8s.io/kube-openapi/pkg/util and pkg/validation/spec), so kube-apiserver and kube-openapi must be kept in lockstep for that Kubernetes release series [2].
Citations:
- 1: https://pkg.go.dev/k8s.io/apiserver@v0.35.4
- 2: https://github.com/kubernetes/apiserver/blob/master/pkg/endpoints/openapi/openapi.go
- 3: Backward incompatibility of OpenAPI changes kubernetes/kubernetes#138247
- 4: Fix: Backward incompatibility of OpenAPI changes kubernetes/kubernetes#138266
Fix k8s.io/kube-openapi alignment with Kubernetes v0.35.4 (go.mod line 167)
- Commit
865597e52e25exists inkubernetes/kube-openapi(dated 2026-06-03). - GitHub security advisory lookup for
k8s.io/kube-openapireturns no reported advisories for the queried package. - Compatibility risk: Kubernetes v0.35.4 is reported to use
k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912, but this PR pinsv0.0.0-20260603220949-865597e52e25while keepingk8s.io/api,k8s.io/apimachinery, andk8s.io/client-goatv0.35.4. Align kube-openapi to the v0.35.4 expected module version (or bump the full Kubernetes dependency set together) to avoid OpenAPI aggregation/generation mismatches.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 167, go.mod pins k8s.io/kube-openapi at commit 865597e52e25
which is out of sync with the other Kubernetes modules (k8s.io/api,
k8s.io/apimachinery, k8s.io/client-go) at v0.35.4; update the
k8s.io/kube-openapi entry to the version Kubernetes v0.35.4 expects
(v0.0.0-20250910181357-589584f1c912) or, alternatively, bump all
Kubernetes-related modules together to a consistent release; modify the
k8s.io/kube-openapi module version string in go.mod (the k8s.io/kube-openapi
line) so it matches the chosen approach and then run go mod tidy to regenerate
go.sum and ensure module graph consistency.
|
@red-hat-konflux[bot]: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR contains the following updates:
8949caa→865597eWarning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.