Skip to content

OCPBUGS-95491: Bump golang.org/x/crypto to v0.52.0 - #10699

Closed
jkaurredhat wants to merge 1 commit into
openshift:release-5.0from
jkaurredhat:update-xcrypto-5.0
Closed

OCPBUGS-95491: Bump golang.org/x/crypto to v0.52.0#10699
jkaurredhat wants to merge 1 commit into
openshift:release-5.0from
jkaurredhat:update-xcrypto-5.0

Conversation

@jkaurredhat

@jkaurredhat jkaurredhat commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR addresses CVE-2026-46597 by updating golang.org/x/crypto from v0.48.0 to v0.52.0 on the release-5.0 branch.

An incorrectly placed cast from bytes to int allowed for server-side panic in the AES-GCM packet decoder for well-crafted inputs in golang.org/x/crypto/ssh.

Update golang.org/x/crypto from v0.48.0 to v0.52.0 to address
CVE-2026-46597 (Denial of Service via crafted AES-GCM packet decoder
inputs in golang.org/x/crypto/ssh).

An incorrectly placed cast from bytes to int allowed for server-side
panic in the AES-GCM packet decoder for well-crafted inputs.

CVSS: 7.5 (Important)
Go Vuln DB: GO-2026-5013
Fix: https://go.dev/cl/781620

Related: OCPBUGS-95491
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@jkaurredhat: This pull request references Jira Issue OCPBUGS-95491, which is invalid:

  • expected Jira Issue OCPBUGS-95491 to depend on a bug targeting a version in 5.1.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

This PR addresses CVE-2026-46597 by updating golang.org/x/crypto from v0.48.0 to v0.52.0 on the release-5.0 branch.

An incorrectly placed cast from bytes to int allowed for server-side panic in the AES-GCM packet decoder for well-crafted inputs in golang.org/x/crypto/ssh.

CVE Details

CVE-2026-46597: Denial of Service via crafted AES-GCM packet decoder inputs

Changes

  • Updated golang.org/x/crypto from v0.48.0 to v0.52.0
  • Ran go mod tidy and go mod vendor
  • Transitive updates: golang.org/x/mod, golang.org/x/net, golang.org/x/sync, golang.org/x/sys, golang.org/x/term, golang.org/x/text, golang.org/x/tools

Test Plan

  • go build ./... passes
  • Go version preserved at 1.25.8
  • Vendor directory updated
  • CI tests pass

Related

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Changes

Go module updates

Layer / File(s) Summary
Update golang.org/x version pins
go.mod
Updated selected golang.org/x/* module versions, leaving oauth2 and time unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

  • openshift/oauth-server#206 — Also requests an golang.org/x/crypto dependency update.
  • openshift/image-based-install-operator#443 — Also updates golang.org/x/crypto.
  • openshift/installer#10170 — Also updates golang.org/x/crypto.
  • openshift/origin#30621 — Also updates golang.org/x/crypto.
  • openshift/machine-api-provider-azure#178 — Also requests an golang.org/x/crypto upgrade.
  • openshift/cluster-baremetal-operator#536 — Also updates golang.org/x/crypto.
  • openshift/cluster-api-provider-ibmcloud#141 — Also updates golang.org/x/crypto.

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only updates go.mod/go.sum and vendored deps; no _test.go or Ginkgo title changes are present, so there are no unstable test names to flag.
Test Structure And Quality ✅ Passed No *_test.go files were changed; this PR is dependency/vendor-only, so the Ginkgo test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo/e2e tests were added; the PR only updates go.mod/go.sum and vendored deps, with no MicroShift-sensitive test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Diff only updates go.mod/go.sum and vendored deps; no new Ginkgo e2e tests were added, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Diff is limited to go.mod/go.sum and vendored Go deps; no deployment manifests, operator code, or controllers changed, so no topology-sensitive scheduling logic was introduced.
Ote Binary Stdout Contract ✅ Passed Only dependency/vendor files changed; diff scan found no added main/init/TestMain/RunSpecs stdout writes or stdout redirection issues.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new or modified Ginkgo/e2e tests were introduced; this PR only updates go.mod, go.sum, and vendor deps, so the IPv6/disconnected check is not applicable.
No-Weak-Crypto ✅ Passed PR only bumps vendored deps; diff shows no added MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed No container/K8s manifests changed; the diff is vendor/go.mod only, and no privileged/hostPID/hostNetwork/hostIPC/allowPrivilegeEscalation settings were introduced.
No-Sensitive-Data-In-Logs ✅ Passed Targeted diff checks found no new log statements or sensitive-value logging in the changed files; this is a dependency/vendor refresh.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately highlights the main dependency update and target version.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from patrickdillon and rna-afk July 20, 2026 15:52
@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jhixson74 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@jkaurredhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tthvo

tthvo commented Jul 21, 2026

Copy link
Copy Markdown
Member

@jkaurredhat Thanks, but I think golang.org/x/crypto is already on v0.52.0 for branch release-5.0. FYI, changes on main will sync to release-5.0 automatically in the 5.0 dev cycle.

golang.org/x/crypto v0.52.0

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@jkaurredhat: This pull request references Jira Issue OCPBUGS-95491. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

This PR addresses CVE-2026-46597 by updating golang.org/x/crypto from v0.48.0 to v0.52.0 on the release-5.0 branch.

An incorrectly placed cast from bytes to int allowed for server-side panic in the AES-GCM packet decoder for well-crafted inputs in golang.org/x/crypto/ssh.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants