Skip to content

[release-4.14] OCPBUGS-102475,OCPBUGS-102487: Bump golang.org/x/net to v0.35.0-sec.3 - #781

Open
MrSanketkumar wants to merge 1 commit into
openshift:release-4.14from
MrSanketkumar:CVE-2026-33814-4.14
Open

[release-4.14] OCPBUGS-102475,OCPBUGS-102487: Bump golang.org/x/net to v0.35.0-sec.3#781
MrSanketkumar wants to merge 1 commit into
openshift:release-4.14from
MrSanketkumar:CVE-2026-33814-4.14

Conversation

@MrSanketkumar

Copy link
Copy Markdown

- What this PR does and why is it needed

Fixes CVE-2026-33814 (CVSS 7.5) in the golang.org/x/net package on the release-4.14 branch.

Rather than bumping golang.org/x/net to v0.56.0 (which would require go version bump), this PR uses the OpenShift sustaining fork github.com/openshift-sustaining/net@v0.35.0-sec.3, which backports the CVE fix onto the existing v0.35.x baseline.

Commands used:

go mod edit -replace golang.org/x/net=github.com/openshift-sustaining/net@v0.35.0-sec.3
go mod tidy && go mod vendor

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 26, 2026
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bb037dc5-98bf-4bb4-ab84-71dabe1df026

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot

Copy link
Copy Markdown

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-102475, which is invalid:

  • expected dependent Jira Issue OCPBUGS-102684 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-102487, which is invalid:

  • expected dependent Jira Issue OCPBUGS-102688 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What this PR does and why is it needed

Fixes CVE-2026-33814 (CVSS 7.5) in the golang.org/x/net package on the release-4.14 branch.

Rather than bumping golang.org/x/net to v0.56.0 (which would require go version bump), this PR uses the OpenShift sustaining fork github.com/openshift-sustaining/net@v0.35.0-sec.3, which backports the CVE fix onto the existing v0.35.x baseline.

Commands used:

go mod edit -replace golang.org/x/net=github.com/openshift-sustaining/net@v0.35.0-sec.3
go mod tidy && go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 26, 2026
@germanparente

Copy link
Copy Markdown

backport-risk-assessed
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2026
@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: germanparente, MrSanketkumar
Once this PR has been reviewed and has the lgtm label, please assign jacobtanenbaum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@MrSanketkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint 47efed4 link true /test lint
ci/prow/unit-test 47efed4 link true /test unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@germanparente

Copy link
Copy Markdown

/label backport-risk-assessed
/label approved

@openshift-ci openshift-ci Bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2026
@redhat-chai-bot

Copy link
Copy Markdown

CI Failure Analysis

This PR has two failing checks. Neither is caused by the CVE dependency changes.

1. ci/prow/unit-test — Pre-existing setup-envtest issue

The unit tests never ran. The Makefile's setup-envtest.sh download from controller-runtime v0.8.3 returns invalid data. This is the same pre-existing infrastructure issue affecting all release branches (4.14–4.18). See #769 for the fix.

2. ci/prow/lint — Pre-existing golangci-lint permission issue

The lint job fails with:

Error: error creating runtime static files directory: mkdir /.local: permission denied
make: *** [Makefile:386: lint] Error 125

This is a golangci-lint issue where the linter tries to create a /.local directory but lacks permissions in the CI pod (running as non-root). This is also a pre-existing issue with the 4.14 branch CI environment, not related to the CVE fix.

Fork Version Verification

  • Base branch release-4.14 uses go 1.18 with golang.org/x/net v0.17.0
  • Fork version v0.35.0-sec.3 requires Go ≥ 1.18, which is compatible ✅

Remaining passing checks

images ✅, ci-index-ingress-node-firewall-bundle ✅, ingress-node-firewall-e2e-metal-ipi ✅, test-fmt


AI-generated. Review for accuracy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants