Skip to content

[release-4.20] OCPBUGS-100327: Fix pod terminal not rendering until resize - #16893

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.20from
openshift-cherrypick-robot:cherry-pick-16892-to-release-4.20
Open

[release-4.20] OCPBUGS-100327: Fix pod terminal not rendering until resize#16893
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.20from
openshift-cherrypick-robot:cherry-pick-16892-to-release-4.20

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jul 31, 2026

Copy link
Copy Markdown

This is an automated cherry-pick of #16892

/assign Leo6Leo

@Leo6Leo @claude @openshift-cherrypick-robot
OCPBUGS-100317: Fix pod terminal not rendering until resize
dce8a7b 
The terminal container starts with 0x0 dimensions and uses
setTimeout(0) to call fitAddon.fit() after setting new dimensions
via React state. This races with React 18's batched state updates —
fit() can fire before the DOM has the correct dimensions, leaving
xterm unable to render content until a manual resize event.

Replace setTimeout(0) with a ResizeObserver (via PatternFly's
getResizeObserver) that fires precisely when the container's actual
DOM dimensions change, guaranteeing fit() always sees the correct
size.

Backport of openshift#16498

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

openshift-merge-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 31, 2026
Merged
6 tasks
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 15a30826-fc66-4637-b8fb-37a12d93f42d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot

openshift-ci-robot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-100317 has been cloned as Jira Issue OCPBUGS-100327. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-100327: Fix pod terminal not rendering until resize

Details

In response to this:

This is an automated cherry-pick of #16892

/assign Leo6Leo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.20] OCPBUGS-100317: Fix pod terminal not rendering until resize [release-4.20] OCPBUGS-100327: Fix pod terminal not rendering until resize Jul 31, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 31, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-100327, which is invalid:

  • expected dependent Jira Issue OCPBUGS-100317 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-100317 to target a version in 4.21.0, 4.21.z, but it targets "4.22.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #16892

/assign Leo6Leo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from cajieh and rhamilto July 31, 2026 02:37
@openshift-ci openshift-ci Bot added the component/core Related to console core functionality label Jul 31, 2026
logonoff
logonoff approved these changes Jul 31, 2026
View reviewed changes

@logonoff logonoff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not affect this release as 4.20 is on react 17 but we can merge this for correctness

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026
@logonoff

logonoff commented Jul 31, 2026

Copy link
Copy Markdown
Member

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 31, 2026
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tmshort

tmshort commented Jul 31, 2026

Copy link
Copy Markdown

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@tmshort: This pull request references Jira Issue OCPBUGS-100327, which is invalid:

  • expected dependent Jira Issue OCPBUGS-100328 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cajieh cajieh Awaiting requested review from cajieh
@rhamilto rhamilto Awaiting requested review from rhamilto
1 more reviewer
@logonoff logonoff logonoff approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@sanketpathak sanketpathak

@Leo6Leo Leo6Leo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/core Related to console core functionality jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @openshift-ci-robot @logonoff @tmshort @sanketpathak @Leo6Leo