[RETEST] OCPBUGS-88063: ovn-kubernetes: Move MNP from ConfigMap to CLI flags

[weliang1]

⚠️ Retest of Merged PR #3072 - For CI Validation Only

This PR contains the exact same changes as the already-merged PR #3072 for CI testing purposes.

Original PR

• Original PR: OCPBUGS-88063: ovn-kubernetes: Move MNP from ConfigMap to CLI flags #3072
• Status: ✅ Already merged into master
• Original commit: 17f08a7

Summary

MultiNetworkPolicy is not enforced on UDN secondary interfaces in OCP 5.0 because ovnkube-control-plane pods do not restart when the ConfigMap is updated with enable-multi-networkpolicy=true.

Root Cause

PR #2944 moved MNP enablement to ConfigMap, but:

1. The ConfigMap hash only includes 008-script-lib.yaml, not 004-config.yaml
2. ovnkube-control-plane has no hash annotation to trigger restarts

Solution

Follow the same pattern as commit f4734c5 (OCPBUGS-78731): move MNP back to CLI flags where pod restart happens automatically on spec changes.

This creates consistency with multicast (also a CLI flag) and avoids the ConfigMap hash timing issues.

Changes

• managed/004-config.yaml: Remove MNP from both ConfigMaps (HyperShift nodes + control plane)
• managed/ovnkube-control-plane.yaml: Add --enable-multi-networkpolicy CLI flag
• self-hosted/004-config.yaml: Remove MNP from ConfigMap
• self-hosted/ovnkube-control-plane.yaml: Add --enable-multi-networkpolicy CLI flag
• ovn_kubernetes_test.go: Update test expectations
• docs/ovn_node_mode.md: Document ConfigMap vs CLI flag feature enablement mechanisms

Testing Focus

• ✅ CI job execution and validation
• ✅ MNP enforcement on UDN Layer2 and Layer3 networks
• ✅ Upgrade paths (4.x → 5.0)
• ✅ HyperShift managed control plane
• ✅ DPU-host mode compatibility
• ✅ Test cases: OCP-77656, OCP-78125, OCP-78259, OCP-77657

Related

• Jira: https://redhat.atlassian.net/browse/OCPBUGS-88063
• Follows pattern from: OCPBUGS-78731 (commit f4734c5)
• Addresses regression from: PR NVIDIA-554: DPU-host mode: use ConfigMap for OVN feature enablement instead of per-node script gating #2944

---

DO NOT MERGE - This is identical to already-merged PR #3072

/hold

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@weliang1: This pull request references Jira Issue OCPBUGS-88063, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

⚠️ Retest of Merged PR #3072 - For CI Validation Only

This PR contains the exact same changes as the already-merged PR #3072 for CI testing purposes.

Original PR

• Original PR: OCPBUGS-88063: ovn-kubernetes: Move MNP from ConfigMap to CLI flags #3072
• Status: ✅ Already merged into master
• Original commit: 17f08a7

Summary

MultiNetworkPolicy is not enforced on UDN secondary interfaces in OCP 5.0 because ovnkube-control-plane pods do not restart when the ConfigMap is updated with enable-multi-networkpolicy=true.

Root Cause

PR #2944 moved MNP enablement to ConfigMap, but:

1. The ConfigMap hash only includes 008-script-lib.yaml, not 004-config.yaml
2. ovnkube-control-plane has no hash annotation to trigger restarts

Solution

Follow the same pattern as commit f4734c5 (OCPBUGS-78731): move MNP back to CLI flags where pod restart happens automatically on spec changes.

This creates consistency with multicast (also a CLI flag) and avoids the ConfigMap hash timing issues.

Changes

• managed/004-config.yaml: Remove MNP from both ConfigMaps (HyperShift nodes + control plane)
• managed/ovnkube-control-plane.yaml: Add --enable-multi-networkpolicy CLI flag
• self-hosted/004-config.yaml: Remove MNP from ConfigMap
• self-hosted/ovnkube-control-plane.yaml: Add --enable-multi-networkpolicy CLI flag
• ovn_kubernetes_test.go: Update test expectations
• docs/ovn_node_mode.md: Document ConfigMap vs CLI flag feature enablement mechanisms

Testing Focus

• ✅ CI job execution and validation
• ✅ MNP enforcement on UDN Layer2 and Layer3 networks
• ✅ Upgrade paths (4.x → 5.0)
• ✅ HyperShift managed control plane
• ✅ DPU-host mode compatibility
• ✅ Test cases: OCP-77656, OCP-78125, OCP-78259, OCP-77657

Related

• Jira: https://redhat.atlassian.net/browse/OCPBUGS-88063
• Follows pattern from: OCPBUGS-78731 (commit f4734c5)
• Addresses regression from: PR NVIDIA-554: DPU-host mode: use ConfigMap for OVN feature enablement instead of per-node script gating #2944

---

DO NOT MERGE - This is identical to already-merged PR #3072

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d663a400-606b-44b5-a989-84a4879a3951

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weliang1
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment