Skip to content

OCPBUGS-98149: use python3 instead of platform-python - #3098

Open
pperiyasamy wants to merge 1 commit into
openshift:masterfrom
pperiyasamy:use_python3
Open

OCPBUGS-98149: use python3 instead of platform-python#3098
pperiyasamy wants to merge 1 commit into
openshift:masterfrom
pperiyasamy:use_python3

Conversation

@pperiyasamy

Copy link
Copy Markdown
Member

RHEL10 on s390x does not have platform-python. Switch to /usr/bin/python3 for ovs-monitor-ipsec invocation.

RHEL10 on s390x does not have platform-python.
Switch to /usr/bin/python3 for ovs-monitor-ipsec
invocation.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Bug Fixes
    • Updated the IPsec monitoring service to use the standard Python 3 executable.
    • Preserved existing command arguments and container behavior.

Walkthrough

Changes

IPsec monitor interpreter update

Layer / File(s) Summary
Update IPsec monitor invocations
bindata/network/ovn-kubernetes/common/ipsec-containerized.yaml, bindata/network/ovn-kubernetes/common/ipsec-host.yaml
Both ovs-monitor-ipsec invocations now use /usr/bin/python3. Their arguments and surrounding container behavior remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (5 errors)

Check name Status Explanation Resolution
Pr Quality ❌ Error The 4-line functional fix is well scoped, but the description lacks Why/What and Testing sections, automated CI platforms, and a bug/issue link. Add Why, What, and Testing sections with applicable automated CNO CI lanes and platforms, and link the RHEL10/s390x issue.
Unit Tests For Go Changes ❌ Error The PR modifies two bindata YAML templates, but the HEAD-vs-parent diff contains no *_test.go changes. Document a valid no-test justification under “How to verify it” in the PR description, then use “@coderabbitai ignore pre-merge checks” after other pre-merge checks pass.
Docs For Feature And Behavior Changes ❌ Error The PR changes both IPsec runtime manifests, but no docs file changes; this check explicitly requires docs/enabling_ns_ipsec.md for IPsec changes. Update docs/enabling_ns_ipsec.md with the platform requirement, or document why docs are not required and use @coderabbitai ignore pre-merge checks.
Container-Privileges ❌ Error The manifests declare privileged: true and hostNetwork: true; ipsec-host.yaml also declares hostPID: true. Remove these privileges where possible. Otherwise document and narrowly justify the required host access in the manifest review.
Title check ❌ Error The title describes the interpreter change and is under 72 characters, but it does not use the affected component as the required prefix. Prefix the title with the affected component, such as "ovn-kubernetes: Fix ...", while retaining the issue key if required.
✅ Passed checks (19 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Commit Message Quality ✅ Passed The PR has one non-merge commit. Its concise IPSec: subject is scoped, and its body explains the RHEL10 s390x reason and the required change; both files are related.
E2e Tests For Feature Changes ✅ Passed The PR changes only two YAML files; the parent-to-HEAD diff contains no Go changes under pkg/ or cmd/, so this E2E check is not applicable.
Rbac Least Privilege ✅ Passed The parent diff changes only two ovs-monitor-ipsec interpreter lines; no Role or ClusterRole rules change under bindata/ or manifests/.
Stale Project Docs And Config ✅ Passed The commit only changes the interpreter path in two bindata manifests. Project docs and .coderabbit.yaml contain no stale platform-python or ovs-monitor-ipsec reference.
Go And Test Code Quality ✅ Passed The pull request changes only two YAML command paths; the parent diff contains no new or modified Go or test code, so none of the nine Go/test issues apply.
Ai-Generated Code Smell ✅ Passed The commit changes only two interpreter paths; it adds no comments, tests, verbose logic, or AI/tool references.
Stable And Deterministic Test Names ✅ Passed The PR changes only two YAML command invocations; it adds or modifies no Ginkgo test titles or test files.
Test Structure And Quality ✅ Passed The pull request changes only two YAML command paths; it adds or modifies no Ginkgo tests, so these test-quality requirements are not applicable.
Microshift Test Compatibility ✅ Passed The pull request changes only two YAML command paths; it adds no Ginkgo e2e tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only two YAML invocations of ovs-monitor-ipsec; no new Ginkgo e2e tests or test paths are present, so SNO compatibility review is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The patch only changes the ovs-monitor-ipsec interpreter path in two existing DaemonSet scripts; no scheduling constraints or topology-related declarations were added or modified.
Ote Binary Stdout Contract ✅ Passed The PR changes only two YAML interpreter paths; no OTE binary, main/suite setup, or process-level stdout write is added or modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only two YAML command paths; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto ✅ Passed The parent-to-HEAD diff changes only the Python executable path in two invocations; it adds no weak cipher, custom crypto, or secret comparison.
No-Sensitive-Data-In-Logs ✅ Passed The parent diff changes only the Python interpreter path in two invocations; logging flags, arguments, and output statements remain unchanged, with no sensitive-data logging added.
Description check ✅ Passed The description clearly explains the change and its RHEL10 on s390x compatibility requirement.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from mattedallo and taanyas August 3, 2026 15:00
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pperiyasamy
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pperiyasamy

Copy link
Copy Markdown
Member Author

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-ovn-upgrade-ipsec
/test e2e-gcp-ovn-techpreview

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-fdp-qe
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-windows
/test e2e-azure-ovn-upgrade
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-ovn-ipv6-ipsec
/test e2e-ovn-ipsec-step-registry
/test hypershift-e2e-aks

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@pperiyasamy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-techpreview fa64c1d link true /test e2e-gcp-ovn-techpreview
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp fa64c1d link true /test e2e-metal-ipi-ovn-dualstack-bgp
ci/prow/e2e-aws-ovn-upgrade fa64c1d link true /test e2e-aws-ovn-upgrade
ci/prow/5.0-upgrade-from-stable-4.22-e2e-gcp-ovn-upgrade fa64c1d link false /test 5.0-upgrade-from-stable-4.22-e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 fa64c1d link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec fa64c1d link true /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw fa64c1d link true /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
ci/prow/e2e-aws-ovn-fdp-qe fa64c1d link true /test e2e-aws-ovn-fdp-qe

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pperiyasamy pperiyasamy changed the title IPSec: use python3 instead of platform-python OCPBUGS-98149: use python3 instead of platform-python Aug 4, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 4, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@pperiyasamy: This pull request references Jira Issue OCPBUGS-98149, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (core-networking-bot@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

RHEL10 on s390x does not have platform-python. Switch to /usr/bin/python3 for ovs-monitor-ipsec invocation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants