Skip to content

OCPBUGS-99755: OTE: fix AWS endpoint resolution for non-standard partitions #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jul 29, 2026
Merged

OCPBUGS-99755: OTE: fix AWS endpoint resolution for non-standard partitions #494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions openshift-tests/ccm-aws-tests/e2e/aws/helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@ func createAWSClientLoadBalancer(ctx context.Context) (*elbv2.Client, error) {

return elbv2.NewFromConfig(cfg, func(o *elbv2.Options) {
o.Retryer = customRetryer
// Use regional public endpoints to prevent malformed or unreachable
// (from test binary, which usually runs outside cluster's VPC) endpoints.
o.BaseEndpoint = aws.String(fmt.Sprintf("https://elasticloadbalancing.%s.amazonaws.com", cfg.Region))
Comment thread
tthvo marked this conversation as resolved.
}), nil
}

Expand Down Expand Up @@ -136,11 +133,7 @@ func createAWSClientEC2(ctx context.Context) (*ec2.Client, error) {
if err != nil {
return nil, err
}
return ec2.NewFromConfig(cfg, func(o *ec2.Options) {
// Use regional public endpoints to prevent malformed or unreachable
// (from test binary, which usually runs outside cluster's VPC) endpoints.
o.BaseEndpoint = aws.String(fmt.Sprintf("https://ec2.%s.amazonaws.com", cfg.Region))
}), nil
return ec2.NewFromConfig(cfg), nil
}

// getAWSSecurityGroup retrieves a security group by ID using the AWS EC2 client.
Expand Down