NO-JIRA: update owners for CCM-AWS OTE path for SPLAT teeam#468
Conversation
Add SPLAT team ownership for the code the team is developing and maitaining across different variants tested on CI.
|
@mtulio: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
WalkthroughEstablishes ownership and review responsibility for cloud controller manager components by defining approver and reviewer alias groups in a central configuration file and then applying those aliases to test directories for AWS and operator testing. ChangesOwnership and review alias configuration
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Developing this idea with @JoelSpeed . Joel feeling I am doing something wrong because OWNERS says it's generated automatically, would you mind pointing to the right direction, please? |
JoelSpeed
left a comment
There was a problem hiding this comment.
Pre-pixaa, we had some tooling to automatically generate these files. I don't think that will survive moving forward so feel free to move ahead and remove the note about being auto generated
| cccmo-approvers: | ||
| - JoelSpeed | ||
| - damdo | ||
| - elmiko | ||
| - mdbooth | ||
| - nrb | ||
| - racheljpg | ||
| - theobarberbany | ||
| cccmo-reviewers: | ||
| - RadekManak | ||
| - damdo | ||
| - mdbooth | ||
| - nrb | ||
| - racheljpg | ||
| - theobarberbany |
There was a problem hiding this comment.
Given the PIXAA re-org, is there anyone who feels they should no longer be in this list?
updated and converting to ready. |
|
/test unit |
|
unrelated too: /test e2e-aws-ovn |
|
/approve |
|
@JoelSpeed: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test unit |
|
@mtulio: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add SPLAT team ownership for the OTE code parts helping support/maintaining across different variants tested on CI.
Summary by CodeRabbit