Skip to content

build(deps): bump github.com/onsi/ginkgo/v2 from 2.33.1 to 2.34.0 - #1027

Merged
github-actions[bot] merged 1 commit into
mainfrom
dependabot/go_modules/github.com/onsi/ginkgo/v2-2.34.0
Nov 9, 2026
Merged

github-actions[bot] merged 1 commit into
mainfrom
dependabot/go_modules/github.com/onsi/ginkgo/v2-2.34.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 9, 2026

Copy link
Copy Markdown
Contributor

Bumps github.com/onsi/ginkgo/v2 from 2.33.1 to 2.34.0.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.34.0

Features

  • DeferOnFailure registers a callback that runs only when a spec fails - as soon as the failing node returns and before any teardown (JustAfterEach, AfterEach, AfterAll, DeferCleanup) - so it can capture the state teardown is about to destroy. It takes exactly what DeferCleanup takes and shares its scoping: called in BeforeEach/JustBeforeEach/It it covers the spec, in BeforeAll the ordered container, and in BeforeSuite the whole suite. It is also available on GinkgoT(); note that this adds a method to FullGinkgoTInterface, so hand-written implementations of that interface need to add it. See https://onsi.github.io/ginkgo/#capturing-failure-state-deferonfailure

Fixes

  • Progress reporters (AttachProgressReporter) are no longer called while Ginkgo holds an internal lock, so a reporter that calls CurrentSpecReport() or AddReportEntry() no longer stalls for 5 seconds and has its output dropped.
  • --sleep-on-failure now runs after any DeferOnFailure callbacks, also pauses when a spec times out, and no longer pauses if the suite has already been interrupted.
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.34.0

Features

  • DeferOnFailure registers a callback that runs only when a spec fails - as soon as the failing node returns and before any teardown (JustAfterEach, AfterEach, AfterAll, DeferCleanup) - so it can capture the state teardown is about to destroy. It takes exactly what DeferCleanup takes and shares its scoping: called in BeforeEach/JustBeforeEach/It it covers the spec, in BeforeAll the ordered container, and in BeforeSuite the whole suite. It is also available on GinkgoT(); note that this adds a method to FullGinkgoTInterface, so hand-written implementations of that interface need to add it. See https://onsi.github.io/ginkgo/#capturing-failure-state-deferonfailure

Fixes

  • Progress reporters (AttachProgressReporter) are no longer called while Ginkgo holds an internal lock, so a reporter that calls CurrentSpecReport() or AddReportEntry() no longer stalls for 5 seconds and has its output dropped.
  • --sleep-on-failure now runs after any DeferOnFailure callbacks, also pauses when a spec times out, and no longer pauses if the suite has already been interrupted.
Commits
  • 7035669 v2.34.0
  • 6698926 docs: DeferOnFailure notes for library authors and pause-style callbacks
  • b66a63f Add parallel and JSON integration coverage for DeferOnFailure
  • 07edd04 Precompile the fixtures in the multi-suite timeout integration test
  • db1c4c8 Add DeferOnFailure
  • fba28c7 Query progress reporters without holding selectiveLock
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.33.1 to 2.34.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.33.1...v2.34.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-version: 2.34.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Nov 9, 2026
@github-actions
github-actions Bot enabled auto-merge (squash) November 9, 2026 00:33
@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 3

  • WIP
  • deps
  • Do Not Merge

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

@openshift-ci

openshift-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign samanthajayasinghe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

@dependabot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions
github-actions Bot merged commit 8edcc41 into main Nov 9, 2026
8 of 9 checks passed
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.63%. Comparing base (6b8b770) to head (8c2faee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
+ Coverage   56.59%   56.63%   +0.03%     
==========================================
  Files          78       78              
  Lines        6191     6191              
==========================================
+ Hits         3504     3506       +2     
+ Misses       2281     2280       -1     
+ Partials      406      405       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant