Skip to content

[ROSAENG-59914] feat: support ROSA Boundary multi-region NAT egress IPs - #1025

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
xiaoyu74:rosa-boundary-multi-region-trusted-ip
Nov 4, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
xiaoyu74:rosa-boundary-multi-region-trusted-ip

Conversation

@xiaoyu74

@xiaoyu74 xiaoyu74 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

What

  • Extend the ROSA Boundary trusted-IP prefix filter to support staging us-west-2 and production us-east-1/us-west-2.
  • Add regression tests for trusted-IP filtering and verification across all four regional egress IPs.

Why

  • ROSA Boundary is now deployed across two regions in both staging and production. The existing filter only supports staging us-east-1, causing the new NAT egress IPs to be excluded from isolated cloud access even when trusted in OCM.
  • This follows the existing approach while preserving the current filtering behavior.

For Reviewers

  • Verified the NAT gateway egress IPs against the AWS VPC configurations in the ROSA Boundary staging and production accounts:
  • AWS account, region, EgressIP mapping
rosa-boundary-stage (150100906299) -> us-east-1 -> 54.243.179.5
rosa-boundary-stage (150100906299) -> us-west-2 -> 52.38.205.178
rosa-boundary-prod (514903006123) -> us-east-1 -> 3.87.149.155
rosa-boundary-prod (514903006123) -> us-west-2 -> 34.210.218.56

For Reference

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Walkthrough

The ROSA Boundary trusted-IP filter now accepts the 54.243, 52.38, 3.87, and 34.210 prefixes. Tests cover enabled and disabled entries, trusted-list filtering, and policy generation for the four regional egress IPs.

Changes

ROSA Boundary trusted IP filtering

Layer / File(s) Summary
Expand trusted-IP filtering and coverage
cmd/ocm-backplane/cloud/common.go, cmd/ocm-backplane/cloud/common_test.go
The filter accepts four ROSA Boundary egress IP prefixes. Tests check that enabled IPs are retained as /32 and appear in generated policies, while disabled entries and an unrelated IP are excluded.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: Minimal · up to 9569a

The new regional prefixes are supported, with no merge-blocking risk identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the ROSA Boundary multi-region NAT egress IP support, which is the main change. The raw summary shows trusted-IP filtering extended to the 54.243, 52.38, 3.87, and 34.210 prefixes, and…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the ROSA Boundary multi-region NAT egress IP support, which is the main change. The raw summary shows trusted-IP filtering extended to the 54.243, 52.38, 3.87, and 34.210 prefixes, and the tests cover the four regional egress IPs. The title also includes a Jira-style ticket tag and a conventional-commit 'feat:' prefix, which are acceptable and do not make it misleading. It is concise, single-sentence, and specific enough for a teammate scanning history.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between abda41e and 9569afb.

Files selected for processing: 2
  • cmd/ocm-backplane/cloud/common.go
  • cmd/ocm-backplane/cloud/common_test.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@openshift-ci
openshift-ci Bot requested review from BATMAN-JD and bmeng November 4, 2026 06:03
@openshift-ci

openshift-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@xiaoyu74: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.63%. Comparing base (abda41e) to head (9569afb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
+ Coverage   56.57%   56.63%   +0.05%     
==========================================
  Files          78       78              
  Lines        6188     6191       +3     
==========================================
+ Hits         3501     3506       +5     
+ Misses       2281     2280       -1     
+ Partials      406      405       -1     
Files with missing lines Coverage Δ
cmd/ocm-backplane/cloud/common.go 57.14% <100.00%> (+0.39%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RaphaelBut

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2026
@openshift-ci

openshift-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RaphaelBut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 6b8b770 into openshift:main Nov 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants