Repository navigation
[ROSAENG-59914] feat: support ROSA Boundary multi-region NAT egress IPs - #1025
Conversation
|
No actionable comments were generated in the recent review. WalkthroughThe ROSA Boundary trusted-IP filter now accepts the ChangesROSA Boundary trusted IP filtering
Estimated code review effort: 2 (Simple) | ~8 minutes Change: Feature Merge Risk:
|
|
@xiaoyu74: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
+ Coverage 56.57% 56.63% +0.05%
==========================================
Files 78 78
Lines 6188 6191 +3
==========================================
+ Hits 3501 3506 +5
+ Misses 2281 2280 -1
+ Partials 406 405 -1
🚀 New features to boost your workflow:
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RaphaelBut The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What
us-west-2and productionus-east-1/us-west-2.Why
us-east-1, causing the new NAT egress IPs to be excluded from isolated cloud access even when trusted in OCM.For Reviewers
For Reference
ocm-backplanerelease and ROSA Boundary container image refresh before E2E validation in the new regions.