Skip to content

HYPERFLEET-1762 - chore: narrow OWNERS to area owners and aliases - #68

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-hyperfleet:mainfrom
ciaranRoche:HYPERFLEET-1200-owners-files
Oct 13, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift-hyperfleet:mainfrom
ciaranRoche:HYPERFLEET-1200-owners-files

Conversation

@ciaranRoche

@ciaranRoche ciaranRoche commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Replaces the flat list of approvers and reviewers with area owners from the
ownership document: https://github.com/openshift-hyperfleet/architecture/blob/main/hyperfleet/docs/owners.md
(in review in openshift-hyperfleet/architecture#232 until it merges).

  • OWNERS_ALIASES holds the names, OWNERS files reference aliases and carry area labels
  • a merge now needs an approver for every touched path
  • Blunderbuss requests reviewers from the area's pool

Why

Today every repository lists the same seventeen people as approvers and
reviewers, so review requests route at random and any one of them can merge
anything alone. Named areas put the request in front of the people who know the
code and make an approver accountable for what merges.

The same criteria were applied to everyone at launch, using the last three
sprints. Reviewer and approver status follows the criteria in the ownership
document and nothing else.
The path to reviewer and approver is written there.

Generated from hyperfleet/docs/owners.yaml in the architecture repository.
Changes to ownership are a PR to that file, then a regenerated OWNERS here.

Tracked in https://redhat.atlassian.net/browse/HYPERFLEET-1762

Merge order

This is one of the nineteen per-repository OWNERS PRs, step 5 of the
repository ownership rollout. It merges after the ownership document and the Prow onboarding PR, and only
when the hold is lifted. The team session that announces the model has already
happened.

  1. HYPERFLEET-1762 - docs: repository ownership document, OWNERS generator and review rules architecture#232, ownership document and generator.
  2. HYPERFLEET-1762 - feat: validate the PR title only in --pr mode hyperfleet-hooks#17, commitlint validates the PR title only, then the v0.3.0 tag.
  3. openshift-hyperfleet: onboard five repositories to Prow and require the tide context on repositories without jobs openshift/release#86872, Prow onboarding and the tide context. Independent of 1 and 2.
  4. Team session. Done, held with the team the week of 5 October.
  5. This PR. The nineteen per-repository OWNERS PRs, after 1 and 3, when the hold is lifted:
  6. HYPERFLEET-1762 - ci: squash on merge for openshift-hyperfleet, hooks v0.3.0 openshift/release#86873, squash on merge and the commitlint pin bump, after 2.
  7. HYPERFLEET-1762 - feat: group the open PRs digest by area and show requested reviewers hyperfleet-claude-plugins#101, open-PRs digest by area, any time after 5.

/hold

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: f491d8ad-7ce9-4280-862c-b71bab014de9
📥 Commits

Reviewing files that changed from the base of the PR and between 42a7434 and b6be234.

📒 Files selected for processing (2)
  • OWNERS
  • OWNERS_ALIASES
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Contract-related changes are now routed to designated owner and reviewer teams instead of being assigned through individual approver and reviewer lists.
    • Contract ownership and review responsibilities are mapped to their respective team members, and a contract-area label is applied.

The change adds aliases for the contracts-owners and contracts-reviewers teams. It replaces individual approvers and reviewers in OWNERS with those teams and adds the area/contracts label.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b6be2

The ownership configuration follows the documented alias and approver/reviewer conventions, with no identified code-level blocker to merging.

Pre-merge checks · Passed 11
Passed Passed checks (11 passed)
Check name Status Explanation
Title check Passed The title clearly identifies the ownership-scope change and the addition of aliases.
Description check Passed The description directly explains the OWNERS and OWNERS_ALIASES changes, their purpose, rollout order, and merge conditions.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output Passed The pull request changes only OWNERS and adds OWNERS_ALIASES. The diff contains no Go or other source files and no slog, log, logr, zap, or fmt.Print* statements. SEC-02 is not triggered…
No Hardcoded Secrets Passed PASS. The pull request changes only OWNERS and adds OWNERS_ALIASES. The added values are team aliases and usernames. No API keys, tokens, passwords, private keys, embedded URL credentials, base64 …
No Weak Cryptography Passed PASS — The pull request changes only OWNERS and adds OWNERS_ALIASES. The diff contains no cryptographic code, cryptographic primitives, secret comparisons, or custom cryptographic implementation. …
No Injection Vectors Passed PASS — The pull request changes only OWNERS and adds OWNERS_ALIASES. The diff contains no SQL queries, fmt.Sprintf, exec.Command/exec.CommandContext, template.HTML, or YAML unmarshalling. …
No Privileged Containers Passed PASS: The pull request changes only OWNERS and OWNERS_ALIASES. These files are not Kubernetes/OpenShift manifests, Helm templates, or Dockerfiles. The patch adds no privileged-container setting or…
No Pii Or Sensitive Data In Logs Passed PASS: The pull request changes only OWNERS and adds OWNERS_ALIASES. The diff contains no logging statements or runtime code, so it cannot introduce PII, session IDs, raw request or response body l…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
✨ Simplify code
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

This was referenced Oct 12, 2026
@ciaranRoche ciaranRoche changed the title HYPERFLEET-1200 - chore: narrow OWNERS to area owners and aliases HYPERFLEET-1762 - chore: narrow OWNERS to area owners and aliases Oct 12, 2026
@ciaranRoche
ciaranRoche force-pushed the HYPERFLEET-1200-owners-files branch from bc3baa7 to b6be234 Compare October 12, 2026 11:44
@ciaranRoche
ciaranRoche marked this pull request as ready for review October 13, 2026 14:10
@ciaranRoche

Copy link
Copy Markdown
Contributor Author

/unhold

@rafabene

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci

openshift-ci Bot commented Oct 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rafabene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit cf98a1c into openshift-hyperfleet:main Oct 13, 2026
3 checks passed
openshift-merge-bot Bot added a commit to openshift-hyperfleet/hyperfleet-adapter that referenced this pull request Oct 13, 2026
## What changed

Replaces the flat list of approvers and reviewers with area owners from
the
ownership document:
https://github.com/openshift-hyperfleet/architecture/blob/main/hyperfleet/docs/owners.md
(in review in openshift-hyperfleet/architecture#232 until it merges).

- OWNERS_ALIASES holds the names, OWNERS files reference aliases and
carry area labels
- a merge now needs an approver for every touched path
- Blunderbuss requests reviewers from the area's pool

## Why

Today every repository lists the same seventeen people as approvers and
reviewers, so review requests route at random and any one of them can
merge
anything alone. Named areas put the request in front of the people who
know the
code and make an approver accountable for what merges.

**The same criteria were applied to everyone at launch, using the last
three
sprints. Reviewer and approver status follows the criteria in the
ownership
document and nothing else.** The path to reviewer and approver is
written there.

Generated from hyperfleet/docs/owners.yaml in the architecture
repository.
Changes to ownership are a PR to that file, then a regenerated OWNERS
here.

Tracked in https://redhat.atlassian.net/browse/HYPERFLEET-1762

## Merge order

This is one of the nineteen per-repository OWNERS PRs, step 5 of the
repository ownership rollout. It merges after the ownership document and
the Prow onboarding PR, and only
when the hold is lifted. The team session that announces the model has
already
happened.

1. openshift-hyperfleet/architecture#232, ownership document and
generator.
2. openshift-hyperfleet/hyperfleet-hooks#17, commitlint validates the PR
title only, then the `v0.3.0` tag.
3. openshift/release#86872, Prow onboarding and the `tide` context.
Independent of 1 and 2.
4. Team session. Done, held with the team the week of 5 October.
5. **This PR.** The nineteen per-repository OWNERS PRs, after 1 and 3,
when the hold is lifted:
   - openshift-hyperfleet/architecture#233
   - openshift-hyperfleet/coderabbit#5
   - **#331 (this PR)**
   - openshift-hyperfleet/hyperfleet-api#398
   - openshift-hyperfleet/hyperfleet-api-spec#68
   - openshift-hyperfleet/hyperfleet-api-spec-template#14
   - openshift-hyperfleet/hyperfleet-applier#58
   - openshift-hyperfleet/hyperfleet-broker#29
   - openshift-hyperfleet/hyperfleet-claude-plugins#100
   - openshift-hyperfleet/hyperfleet-credential-provider#15
   - openshift-hyperfleet/hyperfleet-e2e#164
   - openshift-hyperfleet/hyperfleet-hooks#18
   - openshift-hyperfleet/hyperfleet-infra#108
   - openshift-hyperfleet/hyperfleet-logger#6
   - openshift-hyperfleet/hyperfleet-operator#129
   - openshift-hyperfleet/hyperfleet-release#13
   - openshift-hyperfleet/renovate-config#5
   - openshift-hyperfleet/hyperfleet-sentinel#280
   - openshift-hyperfleet/.github#1
6. openshift/release#86873, squash on merge and the commitlint pin bump,
after 2.
7. openshift-hyperfleet/hyperfleet-claude-plugins#101, open-PRs digest
by area, any time after 5.

/hold
openshift-merge-bot Bot pushed a commit to openshift-hyperfleet/hyperfleet-claude-plugins that referenced this pull request Oct 14, 2026
…quested reviewers (#101)

## What changed

- The open-PRs digest groups PRs by their `area/*` label (first area as
the group, others inline, "No area" last) and shows, per PR, the
requested reviewers and business days since the request. A pending
request older than one business day on a non-draft PR is flagged. Risk
scoring, tiers and the Slack message shape are unchanged.
- `collect-data.sh` reads `review_requested` events from the issue
timeline so the request time is real, with PR `createdAt` as the
fallback.
- `prioritization-algorithm.md` and `output-format.md` replace "review
requests are ignored because reviewers are auto-assigned" with the new
rule: requests come from the area's OWNERS pool and are the reviewer of
record.
- `references/github-repos.md` is the current nineteen repositories
(archived and out-of-scope ones removed, `hyperfleet-api-spec-template`
added).
- `bugs-triage/references/owners.csv` aligned with the ownership areas.
- `CONTRIBUTING.md` and `AGENTS.md`: plugin OWNERS files reference
aliases from the root `OWNERS_ALIASES` and are generated from the
ownership document in the architecture repository.
- `hyperfleet-work-triage` bumped to 0.4.0.

## Why

Prow now labels PRs by area and requests reviewers from the area's
OWNERS pool. The digest is what tells an approver every morning that a
PR is waiting on them, so it has to show the area and the reviewer of
record rather than ignoring requests.

## How to test

```text
bash hyperfleet-work-triage/skills/open-prs/scripts/tests/run-tests.sh
```

96 tests pass. A live run of `collect-data.sh --repo hyperfleet-adapter`
returned real request timestamps from the timeline for adapter#330.

Tracked in https://redhat.atlassian.net/browse/HYPERFLEET-1762

## Merge order

This is step 7 of the HyperFleet repository ownership rollout. It can
merge any time after the area labels exist (they do), and is most useful
once the OWNERS PRs (step 5) have merged.

1. openshift-hyperfleet/architecture#232, ownership document and
generator.
2. openshift-hyperfleet/hyperfleet-hooks#17, commitlint validates the PR
title only, then the `v0.3.0` tag.
3. openshift/release#86872, Prow onboarding and the `tide` context.
Independent of 1 and 2.
4. Team session. Done, held with the team the week of 5 October.
5. The nineteen per-repository OWNERS PRs, after 1 and 3, when the hold
is lifted:
   - openshift-hyperfleet/architecture#233
   - openshift-hyperfleet/coderabbit#5
   - openshift-hyperfleet/hyperfleet-adapter#331
   - openshift-hyperfleet/hyperfleet-api#398
   - openshift-hyperfleet/hyperfleet-api-spec#68
   - openshift-hyperfleet/hyperfleet-api-spec-template#14
   - openshift-hyperfleet/hyperfleet-applier#58
   - openshift-hyperfleet/hyperfleet-broker#29
   - #100
   - openshift-hyperfleet/hyperfleet-credential-provider#15
   - openshift-hyperfleet/hyperfleet-e2e#164
   - openshift-hyperfleet/hyperfleet-hooks#18
   - openshift-hyperfleet/hyperfleet-infra#108
   - openshift-hyperfleet/hyperfleet-logger#6
   - openshift-hyperfleet/hyperfleet-operator#129
   - openshift-hyperfleet/hyperfleet-release#13
   - openshift-hyperfleet/renovate-config#5
   - openshift-hyperfleet/hyperfleet-sentinel#280
   - openshift-hyperfleet/.github#1
6. openshift/release#86873, squash on merge and the commitlint pin bump,
after 2.
7. **This PR.** #101,
open-PRs digest by area, any time after 5.

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants