Skip to content

chore(scanner): add placeholder for storage Account HTTPS enforcement… - #242

Open
Ablaze005 wants to merge 4 commits into
openshield-org:devfrom
Ablaze005:feature/storage-https-enforcement
Open

chore(scanner): add placeholder for storage Account HTTPS enforcement…#242
Ablaze005 wants to merge 4 commits into
openshield-org:devfrom
Ablaze005:feature/storage-https-enforcement

Conversation

@Ablaze005

@Ablaze005 Ablaze005 commented Aug 8, 2026

Copy link
Copy Markdown

New Rule: Enforce HTTPS‑Only for Azure Storage Accounts

This PR adds a new rule:

Rule ID: AZ-STORAGE-HTTPS-001
Category: Storage
Severity: HIGH
Purpose: Detect Storage Accounts that do not enforce HTTPS‑only traffic.

Included

-New rule file: az_stor_006.py
-Full scan logic using the new rule architecture (no AzureClient dependency)
-Unit tests:
1)test_storage_https_disabled
2)test_storage_https_enabled

Why this rule matters

Storage Accounts that allow HTTP traffic expose data to interception and downgrade attacks.
This rule helps enforce secure transport requirements.

Testing

All tests pass:
..

Ran 2 tests in 0.00s

OK

DCO Sign‑off

Signed-off-by: Ablaze Pariyarablaze123pariyar@gmail.com

Closes #245

@Ablaze005
Ablaze005 marked this pull request as ready for review August 9, 2026 22:01
@ritiksah141

Copy link
Copy Markdown
Collaborator

@Ablaze005 currently the git diff shows 1 file create but zero lines of code, so please re review it and also for the new rules follow the codebase exsisting pattern to keep the consistency

@Ablaze005

Ablaze005 commented Aug 10, 2026 via email

Copy link
Copy Markdown
Author

@ritiksah141

Copy link
Copy Markdown
Collaborator

@Ablaze005, the rule you have added doesn't follow the rules pattern used elsewhere, no framework mapping, the syntax, rule conventions. The rules own playbook is missing and many things missing.

So, before updating the PR I would suggest to go through the codebase understand the syntax, writing style and strucutre, and then re write the whole after that provide the evidence if the rule you trying to add is being tested instead of just adding the seperate test file as we have not approched the method of each-rules/each-test files as you can see the test files under the openshield/tests - tests are being categorized under its category only there is one wxception for the az_pqc rule and lastly provide the testing validation in the PR as well and add NOTE section to look for the review to make it more conivenence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add rule for Azure Storage HTTPS enforcement (AZ-STORAGE-HTTPS-001)

2 participants