Skip to content

Mark ONVIF reference headers and redact camera logs - #1033

Merged
matteius merged 6 commits into
mainfrom
ai-findings-autofix/src-video-onvif_detection.c
Nov 20, 2026
Merged

matteius merged 6 commits into
mainfrom
ai-findings-autofix/src-video-onvif_detection.c

Conversation

@matteius

@matteius matteius commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Mark every top-level endpoint reference parameter with wsa:IsReferenceParameter="true" before serialization. Add an HTTP fixture that creates a PullPoint, stores its endpoint reference, then verifies the subsequent PullMessages destination and SOAP headers. Redact credentials and query strings in ONVIF camera URL logs using the existing URL utility, with a token-bearing log test. The focused ONVIF transport suite passes.

matteius and others added 4 commits November 20, 2026 01:15
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@matteius matteius changed the title Potential fixes for 3 code quality findings Mark ONVIF reference headers and redact camera logs Nov 20, 2026
@matteius
matteius marked this pull request as ready for review November 20, 2026 06:22
@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/video/onvif_detection.c 81.81% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@matteius
matteius merged commit ac00950 into main Nov 20, 2026
7 of 12 checks passed
@matteius
matteius deleted the ai-findings-autofix/src-video-onvif_detection.c branch November 20, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant