Repository navigation
Keep ONVIF reference parameters as direct SOAP headers - #1030
Merged
matteius merged 3 commits intoNov 20, 2026
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
matteius
marked this pull request as ready for review
November 20, 2026 05:58
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Generated by tools/rust-transpile/generate.py for 3bdcda1.
matteius
deleted the
ai-findings-autofix55/src-video-onvif_detection.c
branch
November 20, 2026 06:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReferenceParameters must be direct SOAP header children. The generated wrapper changed their WS-Addressing meaning, so this change keeps the direct children and rejects camera-supplied namespace bindings that would rebind the SOAP or WS-Addressing prefixes. Adds tests for direct header placement and malicious namespace rebinding. The focused ONVIF transport suite passes.