Skip to content

Keep ONVIF reference parameters as direct SOAP headers - #1030

Merged
matteius merged 3 commits into
mainfrom
ai-findings-autofix55/src-video-onvif_detection.c
Nov 20, 2026
Merged

matteius merged 3 commits into
mainfrom
ai-findings-autofix55/src-video-onvif_detection.c

Conversation

@matteius

@matteius matteius commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

ReferenceParameters must be direct SOAP header children. The generated wrapper changed their WS-Addressing meaning, so this change keeps the direct children and rejects camera-supplied namespace bindings that would rebind the SOAP or WS-Addressing prefixes. Adds tests for direct header placement and malicious namespace rebinding. The focused ONVIF transport suite passes.

matteius and others added 2 commits November 20, 2026 00:53
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@matteius matteius changed the title Potential fix for 1 code quality finding Keep ONVIF reference parameters as direct SOAP headers Nov 20, 2026
@matteius
matteius marked this pull request as ready for review November 20, 2026 05:58
@codecov

codecov Bot commented Nov 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Generated by tools/rust-transpile/generate.py for 3bdcda1.
@matteius
matteius merged commit 242ae83 into main Nov 20, 2026
4 of 12 checks passed
@matteius
matteius deleted the ai-findings-autofix55/src-video-onvif_detection.c branch November 20, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant