Closed
Align tiling scale math with MIN_MODEL_PX invariant and fix mismatched test intent#9
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Align tiling scale math with MIN_MODEL_PX invariant and fix mismatched test intent
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses all review-thread comments on PR #8 by tightening tiling scale rounding behavior, removing dead imports, and correcting a test scenario that did not exercise the path it claimed to validate.
Tiling region size rounding
plan_tiles()to computeregion_w/region_husing floor-based rounding where required-scale math is applied, preventing crops from becoming larger than intended due toceil(...).min_object_pxtarget does not drop belowMIN_MODEL_PXafter resize/letterbox edge rounding.Test correction for overflow/truncation behavior
tests/test_tiling.pywhose input contradicted its own intent (“very smallmin_object_pxexplodes the grid”).Code hygiene
dataclasses.replaceimport fromutils/tiling.py(including duplicate occurrence), eliminating lint noise.