Repository navigation
Fix workflow builder editing and validation findings - #245
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the five workflow-builder JavaScript findings and the validation-response finding. Stage controls now update once without changing group and field arrays into strings. Saved stage text is assigned through DOM properties, markup attributes and inline node identifiers are escaped, approval group roles survive edits, weekly day zero is preserved, and unsupported Daily Digest is removed. The API returns messages from known builder validators while keeping unexpected ValidationError details generic.
Validation: pytest -q (1,145 passed, 3 skipped); npm test (226 passed); Ruff lint and format checks passed.