Repository navigation
Scope auto approval failures to active workflow rounds - #242
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the remaining auto-approval finding after #241 was closed.
A send-back creates fresh tasks on the same submission, so a returned task from a completed round could permanently block auto-approval. This change identifies a new round when a completed return is followed by a later task on the same workflow track. Failures on other tracks and in the current round still block approval. The check now runs before pending tasks are skipped.
Validation: pytest -q (1,133 passed, 3 skipped); Ruff lint and format checks passed.