Add setRetryStrategy to ApacheHttpClient5TransportBuilder - #2086
Merged
Conversation
loggk
requested review from
Bukhtawar,
VachaShah,
Xtansia,
madhusudhankonda,
reta,
saratvemulapalli and
szczepanczykd
as code owners
August 3, 2026 18:34
loggk
force-pushed
the
feat/http5-retry-strategy
branch
from
August 3, 2026 18:34
108c1ff to
cbbb23c
Compare
reta
requested changes
Aug 9, 2026
Signed-off-by: Logan Kennedy <kennedylogan22@gmail.com>
loggk
force-pushed
the
feat/http5-retry-strategy
branch
from
August 11, 2026 00:49
cbbb23c to
808d243
Compare
reta
reviewed
Aug 11, 2026
reta
reviewed
Aug 11, 2026
Signed-off-by: Andriy Redko <drreta@gmail.com>
reta
reviewed
Aug 11, 2026
Signed-off-by: Andriy Redko <drreta@gmail.com>
reta
previously approved these changes
Aug 11, 2026
reta
reviewed
Aug 11, 2026
Signed-off-by: Andriy Redko <drreta@gmail.com>
reta
approved these changes
Aug 11, 2026
reta
added a commit
that referenced
this pull request
Aug 11, 2026
) * Allow enabling automatic retries in ApacheHttpClient5TransportBuilder * Apply suggestion from @reta * Apply suggestion from @reta * Apply suggestion from @reta --------- (cherry picked from commit e421982) Signed-off-by: Logan Kennedy <kennedylogan22@gmail.com> Signed-off-by: Andriy Redko <drreta@gmail.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Logan Kennedy <163435909+loggk@users.noreply.github.com> Co-authored-by: Andriy Redko <drreta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The builder unconditionally calls
disableAutomaticRetries()on the underlyingHttpAsyncClientBuilder. In HttpClient 5 this flag cannot be undone, so a retry strategy set throughHttpClientConfigCallbackis silently ignored and there is no supported way to enable retries.This adds a
setRetryStrategy(HttpRequestRetryStrategy)option to the builder. When set, the strategy is passed through to the http client; when not set, retries stay disabled as before, keeping the default behavior on par with the 4.x http client.A new
RetryStrategyTestverifies both behaviors against a local socket server that fails the first request with a 503: with a retry strategy the request is transparently retried and succeeds, and by default the failure surfaces without a retry.Issues Resolved
Fixes #1738
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.