Run model tests against both JSON mappers instead of picking one at r… - #2085
Merged
Merged
Conversation
…andom Signed-off-by: Logan Kennedy <kennedylogan22@gmail.com>
loggk
requested review from
Bukhtawar,
VachaShah,
Xtansia,
madhusudhankonda,
reta,
saratvemulapalli and
szczepanczykd
as code owners
August 3, 2026 17:42
reta
reviewed
Aug 9, 2026
reta
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ModelTestCasechooses betweenJsonbJsonpMapperandJacksonJsonpMapperwith a singleRandomcoin flip per JVM, so each test run exercises one serialization backend and never the other, chosen at random. A bug affecting only one mapper passes CI about half the time.Changes
ModelTestCasewith JUnit 4Parameterized, running every test against both mappers.@RunWithis inherited and the mapper is injected by field, so none of the 104 subclasses need changes.Verified with
./gradlew :java-client:unitTest: 426 tests become 604, with exactly 178 per mapper and 0 failures. Runs are now deterministic, and failures report which mapper broke (testName[json-b]/testName[jackson]).spotlessJavaCheckpasses.Issues Resolved
Resolves #770
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.