Repository navigation
Fix Eagle/Fusion crash when a design rule param is missing or duplicated - #586
Merged
qu1ck merged 1 commit intoOct 6, 2026
Merged
Conversation
_parse_param_length called logger.warning, but the project Logger only provides warn. Boards without rlMinViaOuter or mlViaStopLimit params, or with one of them listed twice, crashed with AttributeError instead of logging a warning and using the default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FusionEagleParser._parse_param_lengthreads therlMinViaOuterandmlViaStopLimitdesign rule params. It is meant to log a warning and fall back to a default when a param is missing, or to use the first occurrence when it is listed more than once. Both paths calledself.logger.warning(...), but the project'sibom.Loggerwrapper only definesinfo,errorandwarn(warnis what the other 11 call sites in the repo use). Instead of warning, both cases crashed:This affects any
.brd/.fbrdwhose design rules don't include those params, e.g. older or hand-edited files and some exports.This change switches both calls to
self.logger.warn(...). I did this instead of adding awarningalias toLoggerto keep the logger API as it is.Testing
Ran the CLI (
generate_interactive_bomin CLI mode, which usesibom.Logger(cli=True)) on three Eagle test boards:AttributeErrortracebackWARNING rlMinViaOuter not found, defaulting to 0, same formlViaStopLimit, BOM generatedrlMinViaOuterlisted twiceAttributeErrortracebackWARNING Multiple rlMinViaOuter found, using first occurrence, BOM generated🤖 Generated with Claude Code