Repository navigation
Fix Eagle/Fusion unpopulated parts losing silkscreen and holes - #585
Merged
qu1ck merged 1 commit intoOct 6, 2026
Merged
Conversation
_process_footprint skips documentation layer drawings for elements with populate="no", but it did so with return instead of continue. That aborted the whole package loop at the first tDocu/bDocu item, dropping every later silkscreen drawing, dimension wire and hole of that element. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FusionEagleParser._process_footprintintentionally skips documentation-layer drawings (tDocu/bDocu, layers 51/52) for elements withpopulate="no". It did this withreturninstead ofcontinue, and thefor el in package.iter()loop is the whole function, so the first doc-layer item aborted processing of the entire package for that element.As a result, for unpopulated parts every silkscreen drawing, dimension-layer wire and
<hole>that came after the first tDocu/bDocu item in the package was silently dropped. How much was lost depended on element order in the library package.This one-word change (
return→continue) keeps skipping doc-layer drawings for unpopulated parts and processes the rest of the package normally.Testing
Test board with one package placed twice, once populated (
U1) and once withpopulate="no"(U2). Package items in order: silkscreen wire, doc-layer wire, silkscreen wire, silkscreen circle, hole.populate="no")🤖 Generated with Claude Code