Repository navigation
Disable ref lookup when References column is hidden - #583
Merged
qu1ck merged 1 commit intoOct 6, 2026
Merged
Conversation
setShowBOMColumn compared the column name against "references" but the column is named "References", so hiding it never disabled and cleared the ref lookup box. An active lookup kept filtering the BOM by a column that was no longer visible. Also apply the disabled state on page load when References is hidden from a previous session. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setShowBOMColumnis meant to disable and clear the ref lookup box when the References column is hidden, but it compared the column name against"references"while the column is named"References"(as used everywhere else, e.g.entryMatchesandinitDefaults). The branch never ran, so:Changes:
ibom.js: compare against"References", so hiding the column disables the box, clears it and drops its filter (the existing logic), and showing it re-enables the box.util.js(initDefaults): also set the box's disabled state when References is restored as hidden from local storage. Without this the box was enabled again after a reload even though the column was still hidden.Testing
KiCad Arduino_Uno template, local storage cleared before each run:
J1J1, BOM still filtered to 1 rowJ2filters to 1 rowNo console errors.
🤖 Generated with Claude Code