Skip to content

Fix board rotation from CLI/ini not wrapping to -180..180 #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qu1ck merged 1 commit into from
Oct 6, 2026
Merged

Fix board rotation from CLI/ini not wrapping to -180..180 #582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions InteractiveHtmlBom/core/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,8 +600,6 @@ def get_ini_defaults(self):

def set_from_args(self, args):
# type: (argparse.Namespace) -> None
import math

self.kicad_variant = args.kicad_variant

# Html
Expand All @@ -611,7 +609,10 @@ def set_from_args(self, args):
self.show_silkscreen = not args.hide_silkscreen
self.highlight_pin1 = args.highlight_pin1
self.redraw_on_drag = not args.no_redraw_on_drag
self.board_rotation = math.fmod(args.board_rotation // 5, 37)
# Stored in 5 degree steps, wrap to -180..180 range
self.board_rotation = args.board_rotation // 5
if not -36 <= self.board_rotation <= 36:
self.board_rotation = (self.board_rotation + 36) % 72 - 36
self.offset_back_rotation = args.offset_back_rotation
self.checkboxes = args.checkboxes
self.mark_when_checked = args.mark_when_checked
Expand Down