Skip to content

Fix BOM export losing link text and mangling numeric-looking values #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qu1ck merged 1 commit into from
Oct 6, 2026
Merged

Fix BOM export losing link text and mangling numeric-looking values #580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions InteractiveHtmlBom/web/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ function saveBomTable(output) {
for (var node of bomhead.childNodes[0].childNodes) {
if (node.firstChild) {
var name = node.firstChild.nodeValue ?? "";
text += (output == 'csv' ? `"${name}"` : name);
text += (output == 'csv' ? `"${name.replace(/\"/g, '\"\"')}"` : name);
}
if (node != bomhead.childNodes[0].lastChild) {
text += (output == 'csv' ? ',' : '\t');
Expand All @@ -86,16 +86,15 @@ function saveBomTable(output) {
if (node.checked) {
val += '✓';
}
} else if ((node.nodeName == "MARK") || (node.nodeName == "A")) {
val += node.firstChild.nodeValue;
} else {
val += node.nodeValue;
// Text, highlight marks and links (which may contain marks)
val += node.textContent;
}
}
if (output == 'csv') {
val = val.replace(/\"/g, '\"\"'); // pair of double-quote characters
if (isNumeric(val)) {
val = +val; // use number
if (isNumeric(val) && String(+val) === val) {
val = +val; // use number if it is lossless
} else {
val = `"${val}"`; // enclosed within double-quote
}
Expand Down