bugfix: mark Lua subrequests for HTTP/2 error wakeup#2508
Open
tzssangglass wants to merge 4 commits into
Open
Conversation
Mark capture subrequests so OpenResty's nginx core patch can distinguish Lua subrequests from native nginx subrequests such as slice. This keeps the HTTP/2 error wakeup behavior for ngx.location.capture() without broadening it to unrelated nginx subrequests.
Temporarily build against the OpenResty branch carrying the nginx patch needed to exercise the lua_subrequest marker in CI
Temporarily build against the OpenResty branch carrying the nginx patch needed to exercise the lua_subrequest marker in CI
Contributor
Author
|
CI failed: https://github.com/openresty/lua-nginx-module/actions/runs/27470344050/job/81200016506?pr=2508 because Nginx was built without openresty/openresty#1133 (also, can verify that CI success: https://github.com/openresty/lua-nginx-module/actions/runs/27471275778/job/81202516060?pr=2508 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark capture subrequests so OpenResty's nginx core patch can distinguish Lua subrequests from native nginx subrequests such as slice.
This keeps the HTTP/2 error wakeup behavior for ngx.location.capture() without broadening it to unrelated nginx subrequests.
sister PR: openresty/openresty#1133
fix: openresty/openresty#1131
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.