Skip to content

Intgrtns 559 whmcs ssl module v2.0.7 data truncation in csr generation approver email and host names empty incomplete - #8

Open
YumeChaan wants to merge 5 commits into
masterfrom
INTGRTNS-559-WHMCS-SSL-Module-v2.0.7-Data-truncation-in-CSR-generation-approverEmail-and-hostNames-empty-incomplete
Open

Intgrtns 559 whmcs ssl module v2.0.7 data truncation in csr generation approver email and host names empty incomplete#8
YumeChaan wants to merge 5 commits into
masterfrom
INTGRTNS-559-WHMCS-SSL-Module-v2.0.7-Data-truncation-in-CSR-generation-approverEmail-and-hostNames-empty-incomplete

Conversation

@YumeChaan

Copy link
Copy Markdown
Contributor

Fix SSL order creation to use the domain from custom fields instead of the empty WHMCS domain parameter. Also handles wildcard domains correctly when generating the approver email.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@YumeChaan

Copy link
Copy Markdown
Contributor Author

@claude review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates SSL order creation in the Openprovider WHMCS SSL server module to build the order payload using a domain value sourced from service custom fields (instead of WHMCS’s $params['domain'], which can be empty for SSL products) and to handle wildcard domains when composing the approver email domain part.

Changes:

  • Use $params['customfields']['domain'] to populate host_name / host_names and derive the email domain used for approver_email.
  • Strip a leading *. from the domain when generating the approver email’s domain part.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread modules/servers/openprovider_ssl/openprovider_ssl.php Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@YumeChaan
YumeChaan requested a review from avishka-ra August 18, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants