Log child process signal and execution metadata - #2419
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR (part of OPS-4680) enhances observability for command execution in the openops package by logging additional child-process execution metadata when commands exit, improving debugging of failures (including signal terminations).
Changes:
- Capture both
exitCodeand terminationsignalfrom the child processcloseevent. - Log additional execution metadata (
pid,signal, byte sizes for stdout/stderr) on command completion.
Review Summary
Blocking
closecan yield anullexit code (e.g., signal termination), butCommandResult.exitCodeis typed asnumber. The updated code should normalizenullto a non-zero numeric exit code (while still loggingsignal). (See PR comment.)
Non-blocking
- None
Merge recommendation
- Do not merge
ravikiranvm
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Part of OPS-4680