Skip to content

Log child process signal and execution metadata - #2419

Merged
MarceloRGonc merged 1 commit into
mainfrom
mg/OPS-4680
Aug 5, 2026
Merged

Log child process signal and execution metadata#2419
MarceloRGonc merged 1 commit into
mainfrom
mg/OPS-4680

Conversation

@MarceloRGonc

Copy link
Copy Markdown
Contributor

Part of OPS-4680

Copilot AI review requested due to automatic review settings August 5, 2026 09:44
@linear

linear Bot commented Aug 5, 2026

Copy link
Copy Markdown

OPS-4680

@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR (part of OPS-4680) enhances observability for command execution in the openops package by logging additional child-process execution metadata when commands exit, improving debugging of failures (including signal terminations).

Changes:

  • Capture both exitCode and termination signal from the child process close event.
  • Log additional execution metadata (pid, signal, byte sizes for stdout/stderr) on command completion.

Review Summary

Blocking

  • close can yield a null exit code (e.g., signal termination), but CommandResult.exitCode is typed as number. The updated code should normalize null to a non-zero numeric exit code (while still logging signal). (See PR comment.)

Non-blocking

  • None

Merge recommendation

  • Do not merge

Comment thread packages/openops/src/lib/command-wrapper.ts
@MarceloRGonc
MarceloRGonc merged commit 69470a6 into main Aug 5, 2026
22 checks passed
@MarceloRGonc
MarceloRGonc deleted the mg/OPS-4680 branch August 5, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants