Skip to content

Add secondary value slot to OverviewCard #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravikiranvm merged 3 commits into from
Aug 4, 2026
Merged

Add secondary value slot to OverviewCard #2416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a5fb3b
Add secondary value slot to OverviewCard
ravikiranvm Jul 30, 2026
aaad500
Render the value slot in a div instead of a p
ravikiranvm Jul 30, 2026
eda50a8
Merge branch 'main' into overview-card-secondary-value
MarceloRGonc Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/ui-components/src/components/overview-card/overview-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ import { cn } from '../../lib/cn';
type OverviewCardProps = {
title: string;
icon: ReactNode;
value: string | number;
value: ReactNode;
/** Rendered baseline-aligned to the right of the value (e.g. secondary currency amounts). */
secondaryValue?: ReactNode;
bottomLineText?: string;
onClick?: () => void;
iconWrapperClassName?: string;
Expand All @@ -16,6 +18,7 @@ const OverviewCard = ({
title,
icon,
value,
secondaryValue,
bottomLineText,
onClick,
iconWrapperClassName,
Expand Down Expand Up @@ -45,7 +48,13 @@ const OverviewCard = ({
{title}
</span>
</div>
<p className="font-bold text-[32px]/[32px] text-foreground">{value}</p>
<div className="flex items-baseline gap-2 flex-wrap">
{/* div, not p: value is a ReactNode and may legally contain non-phrasing content */}
<div className="font-bold text-[32px]/[32px] text-foreground">
{value}
</div>
{secondaryValue}
</div>
{bottomLineText && (
<p className="font-normal text-sm text-gray-400">{bottomLineText}</p>
)}
Expand Down
15 changes: 15 additions & 0 deletions packages/ui-components/src/stories/overview-card/overview-card.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,18 @@ export const CustomIconWrapperClassName: Story = {
iconWrapperClassName: 'bg-green-400',
},
};

/**
* Card with a secondary value rendered baseline-aligned next to the main value
* (e.g. remaining currency amounts for a multi-currency total).
*/
export const WithSecondaryValue: Story = {
args: {
value: '$12.4K',
secondaryValue: (
<span className="text-xs font-medium text-muted-foreground">
+ €3.1K · £980
</span>
),
},
};
Loading