fix(backend): prevent query panic on short packets, optimize IP resolution, and stream checksum calculation - #428
Open
JOsee321 wants to merge 1 commit into
Conversation
…ution, and stream checksums
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix Slice Out-of-Bounds Panic in UDP Query (
query.rs):amt < 11) before slicing buffer headers. Prevents unexpected thread panic when receiving truncated or corrupted UDP packets.Optimize IP Parsing & Eliminate Repeated Regex Compilation (
query.rs):Regex::newcompilation on every query with native standard libraryaddr.parse::<Ipv4Addr>()andsocket_address.ip()matching.Streamed MD5 Checksum Calculation (
commands.rs):f.read_to_end(&mut contents)with a 64KB chunked buffer stream feeding intomd5::Context.Testing