Add Magic Hour MCP server - #21
Conversation
|
hi @runshouse Thanks for the submission. I verified that the registry validation passes, the hosted endpoint completes the MCP handshake, and Before merging, please address the following:
The service itself appears legitimate and reachable, but the current entry does not yet provide a complete or reproducible integration. |
|
Addressed all four points in a4b3234:
|
|
rechecked commit a4b3234. One security blocker surfaced after reviewing the complete tool inventory. The hosted upload_file_to_presigned_url helper accepts both a server-local file path and a caller-provided destination URL. For a public hosted endpoint, this needs documented and tested restrictions on readable paths, allowed destination hosts, and redirects—or the helper should be available only in local deployments. Please address this in the hosted Magic Hour MCP implementation, not only by removing the tool from the registry metadata. I recommend coordinating any implementation details privately with the Magic Hour maintainers. Once the live tool surface is secured and the registry entry is refreshed, I’ll be happy to re-review |
|
Thanks for catching this. I addressed it in the hosted Magic Hour MCP implementation, not just the registry metadata: magichourhq/magic-hour-mcp#57 The fix removes Verified against the deployed Vercel preview: MCP initialize succeeds and I am intentionally leaving this registry PR unchanged until the production implementation is secured; after the live hosted |
Summary
Verification
https://mcp.magichour.ai/tools/listreturns 44 toolspython validate.py: 209 files passed