Repository navigation
Implementation Advice: only echo x-fapi-interaction-id values that are UUIDs - #874
Merged
Merged
Conversation
|
📄 HTML preview Drafts changed in this PR: Preview of 3b09a03; updated on every push. For review only — the official specifications are published at https://openid.net/specs/ |
sakimura
approved these changes
Nov 7, 2026
jogu
previously approved these changes
Nov 11, 2026
sakimura
previously approved these changes
Nov 17, 2026
davetonge-mh
changed the base branch from
davetonge/impl-advice/871-structure
to
master
November 18, 2026 13:22
davetonge-mh
dismissed stale reviews from sakimura and jogu
November 18, 2026 13:22
The base branch was changed.
sakimura
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AS or RS only copies the client's
x-fapi-interaction-idinto the response when it is a UUID, and otherwise sets a new UUID, as it already does when the header is missing. Also cites RFC 9562, which obsoletes RFC 4122. The existing logging clause is unchanged and the FAPI 1.0 errata is not covered.Refs #487