Repository navigation
Upgrade Checkstyle to 14.3.0, PMD to 7.28.0, SpotBugs to 4.10.5 - #593
Conversation
|
I have run this on openhab-core (new findings, PR merged), openhab-addons (PR to be created), webui and distro. Here is the comparison for core: (difference can be explained: 11 unused imports were caused by broken javadoc links, 1 fails positive gone through pmd upgrade, one new) |
- Checkstyle from 12.3.0 to 14.3.0 - PMD from 7.19.0 to 7.28.0 - SpotBugs from 4.9.8 to 4.10.4 Dependency upgrades: - JUnit from 6.0.1 to 6.1.3 - Mockito from 5.21.0 to 5.24.0 - commons-io from 2.21.0 to 2.22.0 - commons-lang3 from 3.20.0 to 3.21.0 - slf4j from 2.0.17 to 2.0.20 - logback from 1.5.23 to 1.6.5 - jsoup from 1.19.1 to 1.23.2 - maven-core from 3.9.12 to 3.10.0 - jakarta.xml.bind-api from 4.0.4 to 4.0.5 - jaxb-runtime from 4.0.6 to 4.0.9 - plexus-compiler-eclipse from 2.16.1 to 2.17.1 - Spotless from 3.10.3 to 3.10.4 - Jetty (tests) from 9.4.50 to 12.1.14 - Saxon 9.1.0.8 replaced by Saxon-HE 12.10 - hamcrest-library 3.0 replaced by hamcrest 3.0 - javax.activation 1.2.0 removed Code changes: - Rewrite MissingJavadocFilterCheck on AbstractCheck, because MissingJavadocTypeCheck can no longer be subclassed - Adapt AuthorTagCheck config to the WriteTagCheck API changes - Align the runtime tool versions with the compile versions (fixes NoSuchMethodError in user builds) Users may see new errors: - Malformed Javadoc now fails the build (javadoc.parse.rule.error) - Missing @author tags are now detected on annotated classes, which were silently skipped before Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
c9e9ccb to
6658bc5
Compare
wborn
left a comment
wborn
left a comment
There was a problem hiding this comment.
This is an initial AI-assisted review.
The dependency upgrades and required API migrations look good overall. CI is passing on Java 21 and 25, and downstream validation has been reported.
Two non-blocking follow-ups are suggested inline: update the SpotBugs Maven plugin alongside the SpotBugs engine, and mark the rewritten MissingJavadocFilterCheck as file-stateful to match upstream Checkstyle's threading contract.
The case group flags were never reset, so after a case without braces, empty lines in later blocks (also in other files) were missed or misreported. Reset them per token and add a regression test. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
wborn
changed the title
2 participants
Dependency upgrades:
Code changes:
Users may see new errors:
@authortags are now detected on annotated classes, which were silently skipped beforeNote: Parts of this PR were generated by AI.