feat!: remove support for local CodeJail#222
Conversation
|
Thanks for the pull request, @MoisesGSalas! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
47fb1c9 to
025acae
Compare
|
Hi @feanil, i would like a little bit of advice and what would be the best way to handle this: A lot of the tests in here rely on running codejail locally to pass (51/814). If I configure an instance of codejail-service that listens to localhost:8550 and set Should we add an skip those fifty tests? Delete them? |
|
I haven't looked at the tests (the workflow run has expired) but I'm guessing that a lot of them exercise the codejail sandboxing functionality. It's probably worth removing a lot of those tests and relying on codejail-service's own test suite for that. (Maybe there are some tests we want to add on that side where coverage is missing.) In general, I would support doing a lot of mocking here with |
025acae to
65108b2
Compare
I rebased the branch so a fresh run should be available. From what I saw, lot of failures are using the unsafe decorator to test the xblock behavior they need to run it via codejail. I'm thinking of mocking |
65108b2 to
1182d7a
Compare
As part of openedx/openedx-platform#36639, CodeJail won't be able to be invoked directly by openedx-platform and instead the remote CodeJail REST service will be the only interface available. A large portion of the tests rely on executing the actual problem code so a small mock implementation of the remote CodeJail service is introduced. The mock is a wrapper around CodeJail's `not_safe_exec` and disregards any kind of sandboxing. Tests that validate sandboxing capabilities were removed considering the remote service has a more comprehensive testing suite.
1182d7a to
bec48a7
Compare
As part of openedx/openedx-platform#36639, CodeJail won't be able to be invoked directly by openedx-platform and instead the remote CodeJail REST service will be the only interface available.
A large portion of the tests rely on executing the actual problem code so a small mock implementation of the remote CodeJail service is introduced. The mock is a wrapper around CodeJail's
not_safe_execand disregards any kind of sandboxing. Tests that validate sandboxing capabilities were removed considering the remote service has a more comprehensive testing suite.Merge checklist:
Check off if complete or not applicable: