feat: replace enterprise support contact-tag import with filter call - #39076
Draft
brobro10000 wants to merge 1 commit into
Draft
feat: replace enterprise support contact-tag import with filter call#39076brobro10000 wants to merge 1 commit into
brobro10000 wants to merge 1 commit into
Conversation
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 8, 2026 12:37
415814a to
66e2c12
Compare
brobro10000
changed the title
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
2 times, most recently
from
September 8, 2026 14:04
66e2c12 to
6c0184e
Compare
ENT-11574 Swaps the direct openedx.features.enterprise_support import in the support contact-us view for a call to the new SupportContactContextRequested openedx-filter. Per pwnage101's review feedback on the filter itself, run_filter now returns a tuple of all its inputs (tags, user) and no longer takes request — pipeline steps that need it fetch it via crum internally. No settings changes here: OPEN_EDX_FILTERS_CONFIG registration for the pipeline step lives in edx-enterprise's own plugin_settings() (enterprise/settings/common.py), per the ENT-11830 ownership handoff. The test now mocks the filter call at the view layer; the enterprise-specific pipeline step behavior is covered by edx-enterprise's own test suite.
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 8, 2026 16:44
db02709 to
22fec67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENT-11574
Swaps the direct
openedx.features.enterprise_supportimport in the support contact-us viewfor a call to the new
SupportContactContextRequestedopenedx-filter. No settings changes inthis PR:
OPEN_EDX_FILTERS_CONFIGregistration for the pipeline step lives entirely inedx-enterprise's own
plugin_settings()(enterprise/settings/common.py), per theENT-11830ownership handoff — already merged in this repo (#38634) well before this branch existed.
(An earlier version of this PR incorrectly re-added
OPEN_EDX_FILTERS_CONFIGtolms/envs/common.py/production.py; that's been reverted.)lms/djangoapps/support/views/enrollments.pyis untouched — this PR is scoped to thecontact-tag filter only.
Related PRs
Merge order (per the enterprise plugin ticket runbook)
This PR merges LAST, only after:
confirmed working.
Do not merge before that sequence completes.
CI note
CI here is expected to be red on Django-app-boot-dependent jobs (migrations checks, pylint,
most test shards) until openedx-filters and edx-enterprise are released and this repo's
requirements/edx/base.txtpin is bumped — CI installs the published PyPI versions(
openedx-filters==3.9.0,edx-enterprise==8.9.4as of this writing), which don't yet containSupportContactContextRequested/the new pipeline step. This is the same situation pwnage101'sown
ENT-11573PR (#38109) went through: opened 2026-03-05, not merged until 2026-08-05, oncethe dependency chain caught up. Not a bug in this diff — it self-resolves per the runbook's
release ordering.
Testing
New:
ContactUsViewTestsinlms/djangoapps/support/tests/test_views.pymocksSupportContactContextRequested.run_filterat the call site — the pipeline-step behavioritself is covered by edx-enterprise's own test suite.
Local devstack integration testing (with the openedx-filters, edx-enterprise, and edx-platform
branches checked out together) is required before any of these PRs merge — see the handoff
prompt below for exact steps.