feat: add username slots#560
Open
brian-smith-tcril wants to merge 2 commits into
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
==========================================
+ Coverage 68.75% 69.73% +0.98%
==========================================
Files 48 50 +2
Lines 432 446 +14
Branches 97 97
==========================================
+ Hits 297 311 +14
Misses 132 132
Partials 3 3 ☔ View full report in Codecov by Sentry. |
arbrandes
approved these changes
Jan 15, 2025
arbrandes
left a comment
arbrandes
left a comment
Contributor
There was a problem hiding this comment.
No objections, looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds slots to allow replacing/modifying the content of the user menu dropdown button (where the username is shown by default)
This should address #521 (comment)