Repository navigation
build: pin Django in the check_keywords tox env - #616
Open
kdmccormick wants to merge 1 commit into
Open
kdmccormick wants to merge 1 commit into
kdmccormick wants to merge 1 commit into
Conversation
`make upgrade` strips Django from requirements/test.txt so that tox can choose the Django version, but the check_keywords env only installed test.txt and has no django52 factor. pip then pulled in the latest Django (now 6.x), which breaks DRF's import of django.utils.cache.cc_delim_re. Install the pinned version from requirements/django.txt. Part of: openedx/public-engineering#574 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kdmccormick
force-pushed
the
kdmccormick/check-keywords-django
branch
from
October 23, 2026 14:37
27a8e19 to
91fc242
Compare
kdmccormick
changed the title
kdmccormick
enabled auto-merge (squash)
October 23, 2026 14:39
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make upgradestrips Django from requirements/test.txt so that tox canchoose the Django version, but the check_keywords env only installed
test.txt and has no django52 factor. pip then pulled in the latest
Django (now 6.x), which breaks DRF's import of
django.utils.cache.cc_delim_re. Install the pinned version from
requirements/django.txt.
Part of: openedx/public-engineering#574
🤖 Generated with Claude Code