docs: add repository-local ECC skills - #205
Open
zhaoxueyan1 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds repository-local Agent Skills under SKILLS/ to standardize how contributors (and agents) set up an ECC checkout, run CLI/Workspace flows, select focused tests, and perform persistent native debugging in tmux; it also registers these skills in CLAUDE.md as authoritative for this repository.
Changes:
- Add
run-and-test-eccskill documenting environment setup (Nix/uv), CLI/Workspace contracts, rerun boundaries, test selection, and import provenance checks. - Add
debug-ecc-in-tmuxskill documenting reproducible GDB/cuda-gdb workflows inside persistent tmux sessions (including attach flows). - Register both repository-local skills in
CLAUDE.mdand addagents/openai.yamlmetadata for each skill.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| SKILLS/run-and-test-ecc/SKILL.md | New skill documenting setup + run/test workflows and Workspace contracts. |
| SKILLS/run-and-test-ecc/agents/openai.yaml | Adds agent UI metadata pointing to $run-and-test-ecc. |
| SKILLS/debug-ecc-in-tmux/SKILL.md | New skill documenting persistent tmux-based native debugging workflows. |
| SKILLS/debug-ecc-in-tmux/agents/openai.yaml | Adds agent UI metadata pointing to $debug-ecc-in-tmux. |
| CLAUDE.md | Registers repository-local skills and states they are authoritative for this checkout. |
Suppressed comments (1)
SKILLS/debug-ecc-in-tmux/SKILL.md:166
- Hard-coding
/usr/bin/gdbcan fail on systems where GDB is not installed there (notably Nix). PrefergdbfromPATHfor portability.
tmux new-session -d -s "$session" -c "$repo" "exec /usr/bin/gdb -p $pid"
tmux attach -t "$session"
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+17
to
+19
| - `SKILLS/debug-ecc-in-tmux/SKILL.md`: persistent GDB/cuda-gdb debugging for | ||
| ECC Python, C++, pybind, iDB/iRT, and CUDA failures. | ||
|
|
Comment on lines
+64
to
+65
| debug_command="exec env SKBUILD_EDITABLE_SKIP=$quoted_skip_paths PYTHONFAULTHANDLER=1 PYTHONUNBUFFERED=1 /usr/bin/gdb --args $quoted_python -m chipcompiler.cli.main run --workspace $quoted_workspace --only place --force --json" | ||
| tmux new-session -d -s "$session" -c "$repo" "$debug_command" |
Comment on lines
+154
to
+155
| ps -eo pid,ppid,stat,etime,cmd | rg 'chipcompiler.cli.main|\.venv/bin/python' | ||
| repo=$(git rev-parse --show-toplevel) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation