Cut 1.41 and write what the store says about it - #169
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e66ca23dd1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The heading closes and every locale gets its release notes. The copy was written when the version was half done, so it named things nobody ended up caring about and missed what shows on the first screen. Hindi and Swedish are not told the app speaks their language again. It never has: there is no Hindi or Swedish in the app, and those two storefronts read the English one. They get another change instead. 1.40 gets the date and the compare link it went out without. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E6tn8P25cBDmrA67zrhfwN
andiwand
force-pushed
the
claude/cut-1.41
branch
from
August 17, 2026 13:25
e66ca23 to
11eb9f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the
Unreleasedheading as 1.41 and writes the "What's New" text for alleleven locales, so the release run has a section to build from and a full listing
to upload.
The copy was stale
1.41 already had store copy in every locale - written in #162, before four more
pull requests landed. It named the flat XML formats and the search button and
said nothing about what a returning user meets on the first screen, so the
English is rewritten from the cut section rather than translated as it stood:
PDFs opened in the app before this release; what changed is that odrcore renders
them, and the only way that shows is search and the password prompt. That is what
the first line says now.
Hindi and Swedish are told something else
Eight locales get a bullet saying the app speaks their language again. That is
the biggest change of the release for them, and it is true:
de,es,fr,it,pl,pt-BR,ruandtrare all inknownRegionsand all have an.lproj.Hindi and Swedish do not. The app has never had either, and both storefronts
read the English strings whatever we upload - so that bullet would have promised
those two exactly the thing they are not getting. They take the flat XML line
instead, and so does
en-US, where "the app is in your language again" saysnothing to someone who was always reading English.
Caught by Codex on the first push, and confirmed against
knownRegionsand the.lprojfolders before acting.So
en-USis no longer the source the other eight were translated from. That isdeliberate: it is the copy for a locale the localization fix did not touch.
1.40
It went out on 15 August without its date or its compare link, and
[Unreleased]still pointed at
v1.39, skipping the release entirely. Both fixed here, sincethe link line is being rewritten anyway.
1.41's heading is left undated on purpose - the tag does not exist until the
release run makes it, which is what this repository's changelog asks for.
Checked
changelog_section.py --version 1.41returns the section, so the release runwill not refuse the version.
store_listing.py --version 1.41reports copy inall 11 locales. Every file is 4 bullets, well inside the store's limit.
No version number is edited anywhere:
MARKETING_VERSIONis0.0.0in theproject and the release run supplies it from the dispatch input.
Before dispatching
Read the eleven files - they go to the store as written, and nine of them are in
languages CI cannot check.
🤖 Generated with Claude Code
https://claude.ai/code/session_01E6tn8P25cBDmrA67zrhfwN