Adapt webhook proxy to use HMAC - #1403
Merged
Merged
Conversation
…st user permissions
…ssing - Introduced regex patterns for validating repository names and branch names. - Updated event validation to reject unsafe characters and ensure proper field lengths. - Refactored template parsing to safely encode user-controlled values, preventing JSON injection. - Added comprehensive tests for event validation and template rendering.
…or project key consistency
… enhance security
…or webhook requests
- Introduced common.sh for shared functions used across migration scripts. - Created jira-property-client.sh to manage Jira project properties via REST API. - Developed migrate-bitbucket-webhook-hmac.sh to migrate Bitbucket webhooks, removing trigger_secret and adding HMAC secret. - Implemented migrate-jira-webhook-properties.sh to update Jira properties for WEBHOOK_PROXY.SECRET and WEBHOOK_PROXY.URL. - Added migrate-openshift-webhook-secret.sh to migrate OpenShift secrets for webhook-hmac-secret. - Created migrate-webhooks.sh to orchestrate the migration process for multiple projects, integrating all previous scripts.
# Conflicts: # create-projects/Jenkinsfile # create-projects/create-cd-jenkins.sh # jenkins/webhook-proxy/main.go # jenkins/webhook-proxy/main_test.go
…e secrets to the output
jafarre-bi
requested review from
BraisVQ,
clemensutschig and
oalyman
as code owners
August 28, 2026 07:10
jafarre-bi
requested review from
hrcornejo and
jorge-romero
and removed request for
BraisVQ,
clemensutschig and
oalyman
August 28, 2026 07:31
hrcornejo
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.