Guard against nil Root in apparmor check#811
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
CheckProcess dereferences v.spec.Root.Path when a process sets apparmorProfile, but root is optional in the runtime spec. A config with process.apparmorProfile and no root makes oci-runtime-tool validate panic with a nil pointer dereference. The sibling executable-in-rootfs check on the Args path already guards this with v.spec.Root != nil; apply the same guard here so the apparmor check is skipped when there is no root to resolve the profile path against. Adds a CheckProcess case covering apparmorProfile with no root. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckProcessbuilds the apparmor profile path fromv.spec.Root.Pathwhenever a process setsapparmorProfile, butrootis optional in the OCI runtime spec. Runningoci-runtime-tool validateon a config.json that hasprocess.apparmorProfileand norootpanics with a nil pointer dereference instead of returning a validation result.The sibling check a few lines up (the executable-in-rootfs check on the Args path) already guards this case with
v.spec.Root != nilbefore touchingRoot.Path. This applies the same guard to the apparmor branch, so the profile-path check is skipped when there is no root to resolve it against, matching the existing behavior on the Args path.Added a
TestCheckProcesscase withapparmorProfileset and no root. Before the guard it panics:With the guard it passes.
gofmt -sandgo vet ./validate/are clean.