Fix truncated content URI uploads#184
Open
zerox80 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #181 by preventing partially copied
content://upload cache files from being treated as valid upload sources.Root cause
UploadFileFromContentUriWorkeraccepted any non-empty cache file. If the worker or process was interrupted while copying a largecontent://file into local cache, a later retry could reuse that partial cache file, set the upload size from the truncated cache, and complete TUS successfully with the wrong bytes.Changes
OCTransfer.fileSizebefore upload.content://URI..partfile first, validate the copied size, then rename into the final cache path only after validation succeeds.Validation
git diff --cached --checkpassed before commit../gradlew.bat :opencloudApp:testOriginalDebugUnitTestcould not run locally:JAVA_HOMEis not set and nojavaexecutable is available in PATH../gradlew.bat :opencloudApp:compileOriginalDebugKotlincould not run locally for the same Java environment reason.