PrivacyPolicyActivity: log unhandled non-http(s) URLs as warning#183
Closed
zerox80 wants to merge 1 commit into
Closed
PrivacyPolicyActivity: log unhandled non-http(s) URLs as warning#183zerox80 wants to merge 1 commit into
zerox80 wants to merge 1 commit into
Conversation
When the WebView encounters a non-http(s) URL (e.g. mailto:, tel:) and no external app can handle it, the resulting ActivityNotFoundException is logged at debug level. Promote it to warn with a more descriptive message so user-visible fallback failures are visible in logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the WebView's shouldOverrideUrlLoading encounters a non-http(s) URL (e.g. mailto:, tel:) and no external app can handle it, the resulting ActivityNotFoundException is logged at debug level. Promote it to warn with a more descriptive message so user-visible fallback failures are visible in logs.
Split out from the original TUS upload body error fix to keep concerns focused.